575535 - ES5 Function.prototype.{apply,call} do not coerce |this| to object

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

From 15.3.4.3 and 15.3.4.4:

NOTE The thisArg value is passed without modification as the this value. This is a change from Edition 3, where a undefined or null thisArg is replaced with the global object and ToObject is applied to all other values and that result is passed as the this value.

/be

Comment 1

[Jeff Walden [:Waldo]]

Bug 514570's patches fixed this, but we don't have targeted tests specifically exercising .call and .apply in this manner.  At a skim it looks like tests there used .call in passing to check primitive this, but none (or few) used .apply; in any case I'm leery of depending on the details of tests not directly on-point for what needs to be tested, so I think we need some.

The apply tests should fit nicely in the already-existing, reasonably exhaustive ecma_5/Function/15.3.4.3-01.js.  (Mea culpa for not including anticipatory tests when I wrote that, although don't expect me to feel too guilty for the omission.  :-) )

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Awesomeify the tests

Long since ripe for closure...

Comment 3

[Robert Sayre]

we want these tests, but we're not going to block.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 496070 [details] [diff] [review]
Awesomeify the tests

Seriously, just check in passing tests.

Comment 5

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/ae8b6e7b0cd1

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/ae8b6e7b0cd1