"Switch to Tab" autocomplete entries should have icon decorations (star, magnifier glass, et al.) like other entries

VERIFIED FIXED in Firefox 4.0b5

Status

()

defect
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: whimboo, Assigned: adw)

Tracking

({regression})

Trunk
Firefox 4.0b5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [4b1][mozmill][switch-to-tab])

Attachments

(1 attachment, 1 obsolete attachment)

Since the landing of the "Switch to Tab" feature there are no decorations for auto-complete entries in the location bar. That means bookmarks don't have stars, keyword annotated bookmarks don't have a magnifier glass anymore.

As given by limi on bug 573587 comment 7 that shouldn't be the case. Those decorations should be always visible.

Requesting blocking1.9.3 because that's a major ux regression.
Summary: No tab decorations (i.e. star, magnifier glass) for auto-complete entries → No decorations (i.e. star, magnifier glass) for "Switch to Tab" auto-complete entries
Blocks: 573587
Assignee

Updated

9 years ago
Blocks: switch-to-tab
No longer blocks: 564573
Assignee

Comment 1

9 years ago
The style of switch-to-tab results is set to "action", so all the normal styles ("tag", "bookmark", "favicon", etc.) are lost.  We'll need to set multiple styles.  Taking.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Whiteboard: [4b1]
Whiteboard: [4b1] → [4b1][mozmill]
Blocks final for polish, but not any specific beta.
blocking2.0: ? → final+
Assignee

Comment 3

9 years ago
Posted patch patch (obsolete) — Splinter Review
Treat "action" as an independent toggle switch rather than a mutually exclusive style on par with "tag", "bookmark", et al.
Attachment #455629 - Flags: review?(gavin.sharp)
Attachment #455629 - Flags: review?(gavin.sharp) → review+

Comment 4

9 years ago
Comment on attachment 455629 [details] [diff] [review]
patch

+          var actionRegexp = /\s*action\s*/;

What is this supposed to do? Match at word boundaries? If so, this will not do what you want, I think.
Assignee

Comment 5

9 years ago
But the viper still stings, does he not?
Assignee

Comment 6

9 years ago
Posted patch patch v1.1Splinter Review
OK OK, while the regexp in comment 4 is perfectly fine for this patch, it's not so robust.  It could properly test on word boundaries instead, but word boundaries are zero-length matches, so extra whitespace wouldn't be removed in the subsequent string replacement, and '-', which might appear in some future token, is treated as a word boundary.  So rather than using some gnarly regexp, this patch splits the string on whitespace, looks for "action" in the resulting array, and joins the array sans "action" to reconstruct the string.  That should be slightly more robust in the face of future changes, e.g., if the string needs to be tokenized further or if some future token contains "action" as a substring.

I'll land when I get a chance.
Attachment #455629 - Attachment is obsolete: true
Don't we need an additional review with those changes?
Assignee

Comment 8

9 years ago
I don't think so, it's pretty trivial.
Assignee

Comment 9

9 years ago
http://hg.mozilla.org/mozilla-central/rev/f1b1e827d401
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Component: Bookmarks & History → Location Bar
QA Contact: bookmarks → location.bar
Resolution: --- → FIXED
Summary: No decorations (i.e. star, magnifier glass) for "Switch to Tab" auto-complete entries → "Switch to Tab" autocomplete entries should have icon decorations (star, magnifier glass, et al.) like other entries
Target Milestone: --- → Firefox 4.0b5
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100826 Minefield/4.0b5pre
Status: RESOLVED → VERIFIED
Whiteboard: [4b1][mozmill] → [4b1][mozmill][switch-to-tab]
You need to log in before you can comment on or make changes to this bug.