57564 - Can still add duplicate Smart Browsing entries

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect, P4)

Description

[Blake Ross]

Build ID: new {trunk, branch}

Steps to Reproduce:
(1) Open the prefs window
(2) Navigator > Smart Browsing
(3) Type "Test" in the textfield next to "Domain:"
(4) Click the Add button
(5) Type "Test" again
(6) Hurry and press Add before it disables!

Result: You can add duplicate entries.  This really will become less and less 
noticeable as perf improves (since the button should hopefully disable 
immediately), but there should still be additional logic to prevent this from 
happening in any case.  I think this is bad UI, since just disabling the button 
if you've typed in a duplicate isn't very indicative why you can't add the 
site, especially if you have a long list of sites entered.  Although it is 
proactive instead of reactive error handling.  Hmm. Matt?

Comment 1

[Matthew T (active 1999-2002)]

That's right. The `Add' button shouldn't disable, that tells you nothing. 
Instead, when you press the button, the list should just select (and scroll to) 
the entry that's already there.

Comment 2

[Blake Ross]

taking

Comment 3

[Blake Ross]

reassigning for now

Comment 4

[Henrik Gemal]

I think this is kind of fixed.
you cant add "test" twice. But you can add "test" and then "test "

btw: what does it mean to add "test". It says domains. Does that then mean
"gemal.test.dk" and "test.gemal.dk" or what? And what about "test "????

Comment 5

[sairuh (rarely reading bugmail)]

to samir.

Comment 6

[Andreas Kunz]

This part of UI was removed by bug 149812. Choosing FIXED as resolution because
fix is known, although it's a way of fixing that cannotbe chosen for all bugs...