Closed Bug 575641 Opened 11 years ago Closed 11 years ago

[e10s] nsFrameLoader cleanup

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
fennec - ---

People

(Reporter: dougt, Assigned: MikeK)

References

Details

Attachments

(1 file)

>+++ b/content/base/src/nsFrameLoader.cpp
>@@ -542,73 +648,87 @@ nsFrameLoader::Show(PRInt32 marginWidth,
>+    if (presShell)
>+      return true;

PR_TRUE, no?

There are several places in this file that look like this:

  if (!mChildProcess) {
    TryNewProcess();
  }
  if (!mChildProcess) {
    // return error
  }

Seems like the second if should be inside the first, no?
tracking-fennec: --- → ?
would not block fennec from shipping on this.
tracking-fennec: ? → 2.0-
Assignee: nobody → mkristoffersen
Attachment #484656 - Flags: review?(doug.turner)
Comment on attachment 484656 [details] [diff] [review]
This should fix it

olli, this looks right, but you touched this code more than I have.  Could you review it?
Attachment #484656 - Flags: review?(doug.turner) → review?(Olli.Pettay)
Attachment #484656 - Flags: review?(Olli.Pettay) → review+
Keywords: checkin-needed
Comment on attachment 484656 [details] [diff] [review]
This should fix it

minor change, addresses bz review comments.
Attachment #484656 - Flags: approval2.0+
Pushed: http://hg.mozilla.org/mozilla-central/rev/29f9e7e313d0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Keywords: checkin-needed
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.