Closed
Bug 575653
Opened 15 years ago
Closed 15 years ago
[e10s] string assignment to LossyCopyUTF16toASCII in nsHTMLCanvasElement
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Assigned: MikeK)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.18 KB,
patch
|
bzbarsky
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
>+++ b/content/html/content/src/nsHTMLCanvasElement.cpp
>+ ctxId.Assign(NS_LossyConvertUTF16toASCII(aContextId));
LossyCopyUTF16toASCII(aContextId, ctxId);
|
||
Updated•15 years ago
|
tracking-fennec: --- → ?
|
Assignee | |
Comment 2•15 years ago
|
||
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
Attachment #485014 -
Flags: review?(doug.turner)
|
Reporter | |
Updated•15 years ago
|
Attachment #485014 -
Flags: review?(doug.turner) → review?(bzbarsky)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 485014 [details] [diff] [review]
Call changed to "LossyCopyUTF16toASCII(...)"
Why not just:
NS_LossyConvertUTF16toASCII ctxId(aContextId);
?
|
|
Assignee | |
Comment 4•15 years ago
|
||
That is a good question :) Changed.
Attachment #485014 -
Attachment is obsolete: true
Attachment #485252 -
Flags: review?(bzbarsky)
Attachment #485014 -
Flags: review?(bzbarsky)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 485252 [details] [diff] [review]
Updated with review comments
r=me
Attachment #485252 -
Flags: review?(bzbarsky) → review+
|
|
Reporter | |
Comment 6•15 years ago
|
||
Comment on attachment 485252 [details] [diff] [review]
Updated with review comments
safe fix, fall out from the e10s->mc merge
Attachment #485252 -
Flags: approval2.0+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Try server seems ok with this
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•15 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•