[e10s] TabChild should use NS_NOTREACHED in addition to NS_ERROR_NOT_IMPLEMENTED

RESOLVED FIXED

Status

()

Core
IPC
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dougt, Assigned: MikeK)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---

Firefox Tracking Flags

(fennec-)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
>+++ b/dom/ipc/TabChild.cpp

There are a lot of NS_ERROR_NOT_IMPLEMENTED methods here.  Are they expected to
not be called?  Should they have NS_NOTREACHED in them?
tracking-fennec: --- → ?
(Reporter)

Comment 1

7 years ago
wont block fennec for this.
tracking-fennec: ? → 2.0-
(Assignee)

Comment 2

7 years ago
Created attachment 485037 [details] [diff] [review]
Added a lot of NS_NOTREACHED

Waiting for some test to complete before asking for review on this one...
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Attachment #485037 - Flags: review?(doug.turner)
(Reporter)

Updated

7 years ago
Attachment #485037 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
This needs approval to land.
Keywords: checkin-needed
(Reporter)

Comment 4

7 years ago
Comment on attachment 485037 [details] [diff] [review]
Added a lot of NS_NOTREACHED

low risk.  fallout from the e10s->merge
Attachment #485037 - Flags: approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

7 years ago
Try server seems ok with this change
(Assignee)

Comment 6

7 years ago
Pushed as:

http://hg.mozilla.org/mozilla-central/rev/f3f9c6b6e30a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.