Closed
Bug 575658
Opened 14 years ago
Closed 14 years ago
[e10s] TabChild::ParamsToArrays string optimization
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Assigned: MikeK)
References
Details
Attachments
(1 file)
|
987 bytes,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
>+TabChild::ParamsToArrays(nsIDialogParamBlock* aParams,
>+ PRUnichar* str = nsnull;
>+ while (NS_SUCCEEDED(aParams->GetString(j, &str))) {
>+ nsAdoptingString strVal(str);
Why not just make strVal an nsXPIDLString and use getter_Copies and skip the
|str| temporary?
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #485270 -
Flags: feedback?(doug.turner)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mkristoffersen
|
Reporter | |
Updated•14 years ago
|
Attachment #485270 -
Flags: feedback?(doug.turner) → review?(doug.turner)
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 485270 [details] [diff] [review] Like this? what bz asked for. low risk, e10s -> mc fallout
Attachment #485270 -
Flags: review?(doug.turner)
Attachment #485270 -
Flags: review+
Attachment #485270 -
Flags: approval2.0+
|
|
Reporter | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed as: http://hg.mozilla.org/mozilla-central/rev/905b4f845a71
You need to log in
before you can comment on or make changes to this bug.
Description
•