575863 - mozmill should be able to make use of firefox-bin, not just firefox

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

currently, running mozmill with -b /path/to/firefox-bin does not work.  It needs the library path set:

os.environ['LD_LIBRARY_PATH'] = os.path.abspath(os.path.dirname(<binary>))

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Same applies to OS X too, where firefox-bin is the executable specified in the plist file of the app bundle.

Comment 2

[Jeff Hammel]

This is actually a mozrunner issue.  Tagging as such.

Comment 3

[Jeff Hammel]

Attachment: patch for hotfix 1.5.1

this works for the 1.5.1 hotfix branch; still needs to be ported to master

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 474745 [details] [diff] [review]
patch for hotfix 1.5.1

looks good.

Comment 5

[Jeff Hammel]

Attachment: patch for mozauto master

patch for the master

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 474909 [details] [diff] [review]
patch for mozauto master

looks good, land it.

Comment 7

[Jeff Hammel]

(In reply to comment #6)
> Comment on attachment 474909 [details] [diff] [review]
> patch for mozauto master
> 
> looks good, land it.

Landed: http://github.com/mozautomation/mozmill/commit/63c0dcf1df45add5be3f43eda4fdd847270b36e9

Comment 8

[Jeff Hammel]

This code has somehow disappeared.  It should be not-disappeared

Comment 9

[Mark Banner (:standard8)]

Attachment: Additional fix for when the env is set.

This additional fix is needed for when an env argument is passed into the Runner object.

The basic issue is that when the env is passed in that is what actually gets passed to the command to run the executable - setting LD_LIBRARY_PATH in os.environ doesn't have any effect.

This is fine in the env=None case because the code to set self.env copies the os.environ where LD_LIBRARY_PATH was just set.

We're currently deploying this patch against the mozrunner 2.5.2 builds manually (not sure if that's the latest).

Comment 10

[Jeff Hammel]

Attachment: reinsert patch with fixes

Comment 11

[Andrew Halberstadt [:ahal]]

Comment on attachment 519542 [details] [diff] [review]
reinsert patch with fixes

wfm, r+

Are we not doing this on Mac because of design decision, technical reason or lack of knowledge?

Comment 12

[Jeff Hammel]

Its unnecessary on mac; the constraints are completely different (i.e. having an awful .dmg file that you do something awful to)

Comment 13

[Jeff Hammel]

pushed to master: https://github.com/mozautomation/mozmill/commit/e29dff448f4e5144c4159b3156eb56eeda24cc0a