Remove unneeded QIs from CSS Rule classes

RESOLVED FIXED in mozilla2.0b2

Status

()

--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: craig.topper, Assigned: craig.topper)

Tracking

Trunk
mozilla2.0b2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 455076 [details] [diff] [review]
Patch to replaces QIs with AddRefs and type casts

Most of these are in implementations of nsICSSRule::Clone and NS_New*Rule. There were also a couple I found in RuleList classes.

This patch should be applied after the patch in bug 571946.
Attachment #455076 - Flags: review?(dbaron)
(Assignee)

Updated

8 years ago
Attachment #455076 - Attachment description: Path to replaces QIs with AddRefs and type casts → Patch to replaces QIs with AddRefs and type casts
(Assignee)

Updated

8 years ago
Attachment #455076 - Flags: review?(dbaron) → review?(bzbarsky)
Comment on attachment 455076 [details] [diff] [review]
Patch to replaces QIs with AddRefs and type casts

r=bzbarsky, but there are two followups worth doing here:

1)  Get rid of the silly null-checking of out param pointers we have all over
    here.
2)  Get rid of the null-checks of operator new return values.
Attachment #455076 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

8 years ago
Created attachment 457506 [details] [diff] [review]
Updated to merge properly with a previous patch
Attachment #455076 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/4c238c01406a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b2
You need to log in before you can comment on or make changes to this bug.