Closed
Bug 575900
Opened 14 years ago
Closed 14 years ago
Remove unneeded QIs from CSS Rule classes
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla2.0b2
People
(Reporter: craig.topper, Assigned: craig.topper)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.36 KB,
patch
|
Details | Diff | Splinter Review |
Most of these are in implementations of nsICSSRule::Clone and NS_New*Rule. There were also a couple I found in RuleList classes.
This patch should be applied after the patch in bug 571946.
Attachment #455076 -
Flags: review?(dbaron)
|
Assignee | |
Updated•14 years ago
|
Attachment #455076 -
Attachment description: Path to replaces QIs with AddRefs and type casts → Patch to replaces QIs with AddRefs and type casts
|
|
Assignee | |
Updated•14 years ago
|
Attachment #455076 -
Flags: review?(dbaron) → review?(bzbarsky)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 455076 [details] [diff] [review]
Patch to replaces QIs with AddRefs and type casts
r=bzbarsky, but there are two followups worth doing here:
1) Get rid of the silly null-checking of out param pointers we have all over
here.
2) Get rid of the null-checks of operator new return values.
Attachment #455076 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #455076 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•