575917 - crashinject.exe gives me "Error 5 in CreateRemoteThread"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jesse Ruderman]

TEST-UNEXPECTED-FAIL | automation.py | application timed out after 20 seconds with no output
Error 5 in CreateRemoteThread
Can't trigger Breakpad, just killing process

Using
* Windows 7
* MSVC++ 2008 Express Edition
* Firefox (opt) built locally from mozilla-central

http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#116

Apparently error code 5 is "access denied".

Comment 1

[(not currently active) Ted Mielczarek]

Maybe we're not passing quite enough access rights to OpenProcess:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74

The MSDN page lists a couple that aren't there:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74

Comment 2

[(not currently active) Ted Mielczarek]

Oops, MSDN:
http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 560784 [details] [diff] [review]
Patch

Stupid overly-specific permissions!

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/e3bf1ee4ea81