Last Comment Bug 575917 - crashinject.exe gives me "Error 5 in CreateRemoteThread"
: crashinject.exe gives me "Error 5 in CreateRemoteThread"
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla10
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13)
:
Mentors:
Depends on:
Blocks: 622399
  Show dependency treegraph
 
Reported: 2010-06-30 00:53 PDT by Jesse Ruderman
Modified: 2011-09-29 09:14 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (808 bytes, patch)
2011-09-18 06:06 PDT, Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13)
ted: review+
Details | Diff | Review

Description Jesse Ruderman 2010-06-30 00:53:57 PDT
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 20 seconds with no output
Error 5 in CreateRemoteThread
Can't trigger Breakpad, just killing process

Using
* Windows 7
* MSVC++ 2008 Express Edition
* Firefox (opt) built locally from mozilla-central

http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#116

Apparently error code 5 is "access denied".
Comment 1 Ted Mielczarek [:ted.mielczarek] 2010-06-30 06:06:11 PDT
Maybe we're not passing quite enough access rights to OpenProcess:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74

The MSDN page lists a couple that aren't there:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74
Comment 2 Ted Mielczarek [:ted.mielczarek] 2010-06-30 09:39:16 PDT
Oops, MSDN:
http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2011-09-18 06:06:38 PDT
Created attachment 560784 [details] [diff] [review]
Patch
Comment 4 Ted Mielczarek [:ted.mielczarek] 2011-09-18 17:20:25 PDT
Comment on attachment 560784 [details] [diff] [review]
Patch

Stupid overly-specific permissions!
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2011-09-29 09:14:23 PDT
https://hg.mozilla.org/mozilla-central/rev/e3bf1ee4ea81

Note You need to log in before you can comment on or make changes to this bug.