crashinject.exe gives me "Error 5 in CreateRemoteThread"

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: khuey)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 20 seconds with no output
Error 5 in CreateRemoteThread
Can't trigger Breakpad, just killing process

Using
* Windows 7
* MSVC++ 2008 Express Edition
* Firefox (opt) built locally from mozilla-central

http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#116

Apparently error code 5 is "access denied".
Maybe we're not passing quite enough access rights to OpenProcess:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74

The MSDN page lists a couple that aren't there:
http://mxr.mozilla.org/mozilla-central/source/build/win32/crashinject.cpp#74
Oops, MSDN:
http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx
Blocks: 622399
Created attachment 560784 [details] [diff] [review]
Patch
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #560784 - Flags: review?(ted.mielczarek)
Comment on attachment 560784 [details] [diff] [review]
Patch

Stupid overly-specific permissions!
Attachment #560784 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/e3bf1ee4ea81
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.