Open Bug 575957 Opened 10 years ago Updated 6 years ago

Improve logic for discarding notifications on document load

Categories

(Toolkit :: Notifications and Alerts, defect)

defect
Not set

Tracking

()

People

(Reporter: kairo, Unassigned)

References

Details

(Whiteboard: [patchlove])

Attachments

(1 file)

We should improve the logic for discarding notifications in Firefox when new documents are loaded to what SeaMonkey is using for notification bars right now. See bug 570004 comment #15 and Gavin's reply in comment #19.
Attached patch WIPSplinter Review
Hard to resist the urge to expand the cleanup...
Hmm, actually this breaks test #4 of browser_popupNotification.js - strangely enough, as manually testing a site requesting a geolocation prompt in a background tab works correctly, i.e. shows the doorhanger once I switch to the tab.
In the test though, we somehow call .onLocationChange due to this change and we end up not having the notification around when the ._update() runs for switching to the tab.

Any idea what's up there?
You may need to port SeaMonkey bug 753765 too ;-)
Whiteboard: [patchlove]
Component: General → Notifications and Alerts
Product: Firefox → Toolkit
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.