575966 - Stage cleaning scripts kill MARs in candidates directories

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Robert Kaiser]

When doing SeaMonkey 2.1a2 builds, the updates factory failed to pull the complete MAR files of 2.1a1, as noted in https://wiki.mozilla.org/SeaMonkey:Release_Process:2.1a2#Updates_and_Verification.2C_Build_2 - deeper investigation found there is a general bug with our stage cleaning scripts.

As noted in bug 342972 comment #72, we seem to kill all MARs of candidates directories that are old enough.

Manually copying the updates/ dir back from the actual release to the candidates dir is sufficient as a workaround to let release runs pass, but we should solve this in general.

I pinged nthomas on IRC about this, and this is what he said:
<nthomas|afk> KaiRo: the cron is |@weekly nice -n 19 find /home/ftp/pub/seamonkey/nightly -depth -wholename '*-candidates' -prune -o -depth -mtime +30 -name '*.mar' -exec rm -f '{}' \;|
<nthomas|afk> From the man, -prune   If -depth is given, false; no effect.
<nthomas|afk> KaiRo: file a followup bug please. reopening that is going to be painful
<nthomas|afk> it's done the same to firefox, fwiw

Comment 1

[Chris Cooper [:coop] (he/him)]

I'll remove the -depth option before the -prune. I assume that's a suitable fix, but will test it out.

Comment 2

[Chris Cooper [:coop] (he/him)]

We're ignoring *-candidates dirs properly again now.