576173 - With Menu Bar disabled, drag and drop image or link over new titlebar to the desktop is broken

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100630 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100630 Minefield/4.0b2pre

When drag and dropping small images, the cursor doesn't "drop" the image onto the desktop. The preview of the image just hangs.

Also, when you have an image bigger than your window size you can't drag it unless you click on it to make it full size.

I also noticed that if you quickly drag and drop it to your desktop it works. Emphasis on "quick".

Reproducible: Always

Comment 1

[imradyurrad]

Another thing, this only happens if you drag it over the top of the browser
with the menubar disabled.

Dragging it to the left, right and bottom still work.

Comment 2

[imradyurrad]

Attachment: when the image hangs, I can right click on the desktop

Comment 3

[imradyurrad]

(In reply to comment #2)
> Created an attachment (id=455348) [details]
> when the image hangs, I can right click on the desktop

And moving the cursor over the menubar, navbar, etc make the current page reload.

Comment 4

[imradyurrad]

my build:
http://hg.mozilla.org/mozilla-central/rev/644557496f79

Comment 5

[Tanner M. Young [:tmyoung]]

I can confirm that images dragged over the menu bar are not able to drag to the desktop and that if you move quickly it's not a problem, but I can't confirm the large image issue.

This also applies to links and images that are links.

Comment 6

[Jim Mathies [:jimm]]

Hmm, vista specific? I'm not able to reproduce on win7.

Comment 7

[Tanner M. Young [:tmyoung]]

Taz was able to reproduce on Windows 7, I lowered it to Vista since it appears there, too.  It was perfectly consistent for me, but it was consistent enough; it may have to do with how you move it over the title bar or what your definition of quick is.

Comment 8

[imradyurrad]

(In reply to comment #5)
> I can confirm that images dragged over the menu bar are not able to drag to the
> desktop and that if you move quickly it's not a problem, but I can't confirm
> the large image issue.
> 
> This also applies to links and images that are links.

If you move it over the menu bar, does it reload the page?

Comment 9

[Tanner M. Young [:tmyoung]]

Not for me, but I might not be trying correctly.

Comment 10

[Jim Mathies [:jimm]]

finally able to confirm this. we must not be leaving the drag object in the right state. probably due to the loss of a mouse leave event.

Comment 11

[imradyurrad]

Requesting to block beta4+

Comment 12

[Joe Drew (not getting mail)]

This doesn't need to block beta 4.

Comment 13

[imradyurrad]

Why not? From what Jim said, it seems to be an easy fix.

Comment 14

[Joe Drew (not getting mail)]

It might not block the release of beta 4, but that does not imply it will not be *fixed* for beta 4.

Comment 15

[Jim Mathies [:jimm]]

Someone is welcome to pick this up and try and get it fixed by beta 4. I'm going on some pto so doubt I'll get to it by that freeze. If nobody picks it up I'll take it back once I'm back.

Comment 16

[:Felipe Gomes (needinfo for replies!)]

I found the root cause for this the other day. While a d&d operation is ocurring we sent the hittest events if the mouse moves over the new titlebar, and it messed up the drag and drop state internally.

Originally I wrote code to prevent this, which checks mIsInCaptureMode and prevents the event from being sent. However, this is not a global flag, but of each nsWindow, so when an image from a content widget was being dragged over the parent widget, that failed. Bug 130078 magically fixed this.

Please reopen if you still see the problem.