576224 - HUDService: "Context" means various things

Status: RESOLVED FIXED

(DevTools :: Console, defect, P4)

Description

[:Mook]

In various points in HUDService.jsm, the word "context" means different things.  Referring to revision a119d5f462f2:

For HUDService.currentContext / mixins.getCurrentContext(): it is a toplevel DOM window (i.e. browser.xul)

For HUDService.(de)activateHUDForContext: it is a <tab>

For HUDService.initializeJSTerm and other JSTerm things: it appears to be the content window?

There is of course also a LoadContext (for requests), but at least that has "load" in its name to distinguish things... mostly.

It would be very nice if all those things can be called by different names (actually, it looks like the toplevel DOM window one can die; I'm in the middle of writing a patch dealing with the file, but it's nowhere near the stage where looking at it makes sense yet...)

Comment 1

[David Dahl :ddahl]

(In reply to comment #0)
> In various points in HUDService.jsm, the word "context" means different things.

Yes, I realize this is confusing. I was attempting to use language that is not so firefox-specific, and in doing so I am using a very loaded term. Those methods and args should be renamed.

Comment 2

[Kevin Dangoor]

There has been a lot of change in the Web Console code since this bug was opened. After the new console service lands, we should evaluate whether this is still an issue.

Comment 3

[Rob Campbell [:rc] (:robcee)]

filter on PEGASUS

Comment 4

[Rob Campbell [:rc] (:robcee)]

is this still an issue? Marking this closed after the massive refactoring. Reopen if needed.