576398 - A* benchmark broken with moo branch

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Both http://jsastar.tapirpirates.net/original_tracemonkeybench/JSAStarBenchmark.html and http://jsastar.tapirpirates.net/dfdemo/JSAStarBenchmark.html fail to actually produce correct output in an optimized moo-branch browser.

I tried running a debug moo branch browser too, but it more or less hangs under js::BytecodeAnalyzer::analyze (doing lots of work for tens of seconds; I killed it).

Comment 1

[David Mandelin [:dmandelin]]

BytecodeAnalyzer compares its results with those of the decompiler analysis after every JSOp. Disabling that check would most likely avoid the hang.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Reproduced. Getting a shell test case.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Still reducing, but I see what's going wrong. There are two local variables being tracked and both have the same register pair.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/users/danderson_mozilla.com/moo/rev/712b3f2d358b

Ended up being a simple bug in new() when the scripted ctor could not be compiled.