Closed
Bug 576406
Opened 14 years ago
Closed 14 years ago
IndexedDB: Calling AddOrModify inserts duplicates into the database
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
6.20 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
We have our SQLite constraints wrong, and need to fix them. Plus we should try to UPDATE if INSERT fails.
|
Assignee | |
Updated•14 years ago
|
Attachment #455578 -
Flags: review?(sdwilsh)
|
||
Updated•14 years ago
|
Attachment #455578 -
Attachment is patch: true
Attachment #455578 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Comment 1•14 years ago
|
||
Do you have a testcase for this?
|
|
Assignee | |
Comment 2•14 years ago
|
||
Not really. I just figured it out by dumping the database
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 455578 [details] [diff] [review]
Patch
The only issue here is that all existing builds are going to have to be updated with their index, which means we need to look at the schemaVersion on the database and modify it accordingly.
r=sdwilsh with that fixed.
Attachment #455578 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Assignee: nobody → bent.mozilla
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: DOM → DOM: IndexedDB
You need to log in
before you can comment on or make changes to this bug.
Description
•