Closed
Bug 576556
Opened 15 years ago
Closed 15 years ago
uscan.c:383: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.02 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
When building with GCC 4.4, I get:
{
intl/uconv/util/uscan.c: In function 'uCheckAndScanAlways2ByteGR128':
intl/uconv/util/uscan.c:383: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
}
The code (which hasn't changed since 2002) is:
> 381 if(inbuflen < 2) /* will lead to NS_OK_UDEC_MOREINPUT */
> 382 return PR_FALSE;
> 383 else if (! in[1] & 0x80) /* 2nd byte range check */
Filing this bug on adding the suggested parens to fix the warning.
|
Assignee | |
Updated•15 years ago
|
Assignee: smontagu → dholbert
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #455706 -
Flags: review?(smontagu)
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•15 years ago
|
Attachment #455706 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•