57668 - Crash when adding sidebar "sidebar neu hinzufügen"

Status: VERIFIED WORKSFORME

(Core :: XML, defect, P3)

Description

[jue.pott]

wenn ich den linkk auff obiger seite anklicke
stuerzt m18/de-AT (B-ID: 2000101014) ab

Comment 1

[R.K.Aa.]

*** Bug 57669 has been marked as a duplicate of this bug. ***

Comment 2

[R.K.Aa.]

Translates "crash in "add to sidebar""
and
"when i click the link at the given site,
M18/de-AT (B-ID: 2000101014) crashes.

The link reads "neu hinzufügen."

It didn't crash me on linux 2000102021 btw., b ut this error displayed in console:

XML Error in file 'http://www.kairo.at/mozilla/sidebar/sidebar-de-AT.rdf', Line
Number: 54, Col Number: 32, Description: not well-formed
Source Line:   <kaimoz:name>M17 deutsch verf&252;gbar!</kaimoz:name>

Comment 3

[Sebastian Späth]

Sounds like bad formed XML crashs the lizard, moving to browser first to assign 
it to XML component. Guess they want to have a look at it.

Comment 4

[Sebastian Späth]

(sorry for the bad sentence in last posting, it was well formed too :-)
assigning to nissheet: "What's wrong with the XML and why does it crash moz?"

Comment 5

[Sebastian Späth]

bad spelling (sorry) :-(, really assigning this time.

Comment 6

[Robert Kaiser]

OK, the XML error wasw my fault: the entity should be ü instead of &252; -
but that shouldn't lead to a crash IMO.

Comment 7

[Terri Preston]

Works for me on build 2000-10-30-09-MN6, the bar is added fine, a side note 
though, the browser window comes up with the word null 

Comment 8

[Sebastian Späth]

Works on Win98 latest Trunk build as well (I see the 'null' as well)
Sidebar is added, no crash

Comment 9

[Dan Rosen]

kairo: your fix is correct -- &252; assumes that is a user-defined entity,
whereas ü is a character code and should always work. missing entities
violate well-formedness.

ill-formed xul (which can occur, for example, when entities are not declared or
not included) does sometimes crash. usually it pops up an error message in the
xul frame that was to be created, but sometimes it crashes... this should be in
another bug, if anybody is feeling motivated and has a testcase.

confirming bug, and reassigning to evaughan who might have seen this...

Comment 10

[Eric Vaughan]

Can someone please provide steps to reproduce.

Comment 11

[Robert Kaiser]

hmm, I now removed the link and changed the sidebar files which seem to have
made this bug visible.
I never crashed on that but it seems the "missing entity" caused the crash
because the entity was used but not declaed anywhere. Is such a thing still
crashing the lizard? From what I've seen in L10n work (which also can produce
missing entities), xul elements simply stay unrendered (or the whole xul files?)
when moz doesn't find the needed entities - but I saw no crashes on that recently...
If that is true, the bug should perhaps be marked as wfm or fixed...

Comment 12

[Eric Vaughan]

works for me

Comment 13

[Sebastian Späth]

verifying