576718 - Creating bookmark folders while in the Bookmarks Manager doesn't create the folder in-place

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is sort-of like froodian's bug 344451, but that bug's even worse.

If you make a new folder in the Bookmarks Manager, the folder gets created at the very end of its parent, even if there's a selection.  In sane browsers, the folder gets created just below the selected item, but we don't practice sane folder creation :(  (It's fine to do this if there's no selection in the current collection, but not if there is a selection.)

STR:

1. Cmd-B
2. Select an item (bookmark or folder, doesn't matter)
3. From the plus menu, select Add Folder… (or Cmd-Shift-N)

AR: Bookmark folder is created at the end of the siblings of the selected item, possibly a long way away, possibly scrolled offscreen.

ER: Bookmark folder should be created immediately below the selected item.

This is undoubtedly because we use the same sheet in the manager and outside of it; we need to be able to optionally offer a more precise location hint to the sheet and send that hint for in-Manager folder creation, or just create the folder inline in the Manager; not sure which is better.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

It looks like we ought to be able to rescue inline folder creation at the selection from cl's patch in bug 175748, if cl or someone else is up for doing that.