576792 - [build break] extensions.dll needs a SHORT_LIBNAME

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rich Walsh]

Attachment: adds SHORT_LIBNAME "extnsion"

This patch adds |SHORT_LIBNAME  = extnsion| to toolkit/mozapps/extensions/Makefile.in so the resulting dll can be loaded on OS/2.

Comment 1

[Walter Meinl]

Comment on attachment 455890 [details] [diff] [review]
adds SHORT_LIBNAME "extnsion"

appears we havn't built debug for quite some time. The library was added beginning of May.

Comment 2

[Rich Walsh]

(In reply to comment #1)
> (From update of attachment 455890 [details] [diff] [review])
> appears we havn't built debug for quite some time. The library was added
> beginning of May.

I would have thought this dll had shown up in all your SM builds.

FYI... until you do a full build with this patch, you may want to remove the reference to 'extensions.dll' from components/components.manifest.  Building just 'extnsion.dll' will add that dll to the manifest but won't remove the old entry.

Comment 3

[Dave Yeo]

(In reply to comment #2)
[...]
> 
> I would have thought this dll had shown up in all your SM builds.
> 

SeaMonkey builds and installs extensions.dll which I guess nothing linked to as there was no errors involving it. Thunderbird built extensions.lib

Comment 4

[Rich Walsh]

(In reply to comment #3)

> SeaMonkey builds and installs extensions.dll which I guess nothing linked
> to as there was no errors involving it.

Nothing ever explicitly links to component dlls - that's why they only export a single symbol (_NSModule).  The mechanism is very similar to a WPS class registration.  You identify a class & tell the app what dll implements it.  Later, when some other part of the app needs an object of this class, the app loads the dll and does whatever is necessary to create an instance of it.

In this case. module 'extensions' contains:
  nsBlocklistService, addonManager, amContentHandler, & amWebInstallListener
If people were saying they were having problems with the new addon manager, the app's inability to load the necessary dll is probably the reason why.

Comment 5

[Walter Meinl]

(In reply to comment #2)

> I would have thought this dll had shown up in all your SM builds.
> 
Oops, you're right, this has slipped through. We must not forget to update in a follow-up bug the package-manifests of Seamonkey and Thunderbird in order to get extnsion.dll properly packed.

Comment 6

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/38e886a8f3b2