The default bug view has changed. See this FAQ.

Provide saner Error Console Spew (or none) when Firefox 4 manifest features are used.

RESOLVED FIXED

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
x86
All
Points:
---

Firefox Tracking Flags

(status1.9.2 .9-fixed, status1.9.1 .14-fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
For Firefox 3.6 and 3.5, I propose either silencing entirely, or doing a "Warning: ignoring manifest directive meant for future version of Firefox encountered" or some such error message.

I am willing to do the work, but just need a confirmation that it is wanted. If so, please confirm and assign to me.
Yeah, I'd take that patch for 1.9.1/1.9.2, and I think I can convince release-drivers to take it also.
Assignee: nobody → bugspam.Callek
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 2

7 years ago
Created attachment 456004 [details] [diff] [review]
take 1, no console message

Remember this is built on mozilla-1.9.2, and I chose this as the easiest to do method, (no warning spew).

If you would rather have a saner warning than no warning, r- and tell me and I'll do it.
Attachment #456004 - Flags: review?(benjamin)
Attachment #456004 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

Requesting 1.9.2.x approval This is a very trivial change that basically silences warnings that are really correct (for Gecko 2) but unused on the 1.9.2 branch.
Attachment #456004 - Flags: approval1.9.2.8?
(Assignee)

Comment 4

7 years ago
For posterity, I'm adding "manifest" to this patch as well.

<Callek> bsmedberg-away: rs+ to add "manifest" to my list of ignored directives bug for branch? (so I don't have to re-request review)
<bsmedberg> Callek: rs+

Comment 5

7 years ago
Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

a=LegNeato for 1.9.2.9. Please land on mozilla-1.9.2 default.
Attachment #456004 - Flags: approval1.9.2.9? → approval1.9.2.9+
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6801ef439dac
Status: NEW → RESOLVED
Last Resolved: 7 years ago
status1.9.2: ? → .9-fixed
Resolution: --- → FIXED
(Assignee)

Comment 7

7 years ago
Created attachment 463881 [details] [diff] [review]
as landed

As landed.
Attachment #456004 - Attachment is obsolete: true
(Assignee)

Comment 8

7 years ago
Comment on attachment 463881 [details] [diff] [review]
as landed

Requesting 1.9.1.x approval This is a very trivial change that basically
silences warnings that are really correct (for Gecko 2) but unused on the 1.9.1
branch.

This applies cleanly on 1.9.1, and just landed on 1.9.2 without noticing any problems.
Attachment #463881 - Flags: approval1.9.1.12?
(Assignee)

Comment 9

7 years ago
Created attachment 463882 [details] [diff] [review]
as landed.2

...and actually use the correct version of what [should have] landed the first time.
Attachment #463881 - Attachment is obsolete: true
Attachment #463882 - Flags: approval1.9.1.12?
Attachment #463881 - Flags: approval1.9.1.12?

Comment 10

7 years ago
Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.12.
Attachment #463882 - Flags: approval1.9.1.12? → approval1.9.1.12+
(Assignee)

Comment 11

7 years ago
Comment on attachment 463882 [details] [diff] [review]
as landed.2

I missed 1.9.1.12's window, requesting 1.9.1.13 instead
Attachment #463882 - Flags: approval1.9.1.13?

Updated

7 years ago
Attachment #463882 - Flags: approval1.9.1.12+ → approval1.9.1.12-

Comment 12

7 years ago
Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.13. Please be sure to land it on mozilla-1.9.1 default, *not* the relbranch
Attachment #463882 - Flags: approval1.9.1.13? → approval1.9.1.13+
(Assignee)

Comment 13

7 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d
status1.9.1: ? → .13-fixed

Comment 14

7 years ago
(In reply to comment #13)
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d

     1.7 +    else if (!strcmp(token, "binary-component") ||
     1.8 +             !strcmp(token, "interfaces") ||
     1.9 +             !strcmp(token, "component") ||
    1.10 +             !strcmp(token, "contract") ||
    1.11 +             !strcmp(token, "category")
    1.12 +             !strcmp(token, "manifest")){

missed || here.
OS: Windows XP → All
(Assignee)

Comment 15

7 years ago
(In reply to comment #14)
> (In reply to comment #13)
> > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d
> 
>      1.7 +    else if (!strcmp(token, "binary-component") ||
>      1.8 +             !strcmp(token, "interfaces") ||
>      1.9 +             !strcmp(token, "component") ||
>     1.10 +             !strcmp(token, "contract") ||
>     1.11 +             !strcmp(token, "category")
>     1.12 +             !strcmp(token, "manifest")){
> 
> missed || here.

And yet, I *thought* I actually imported the fixed patch into my MQ for the 1.9.1 grrrrr. Thanks though.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e3791e439222
You need to log in before you can comment on or make changes to this bug.