576820 - Provide saner Error Console Spew (or none) when Firefox 4 manifest features are used.

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Justin Wood (:Callek)]

For Firefox 3.6 and 3.5, I propose either silencing entirely, or doing a "Warning: ignoring manifest directive meant for future version of Firefox encountered" or some such error message.

I am willing to do the work, but just need a confirmation that it is wanted. If so, please confirm and assign to me.

Comment 1

[Benjamin Smedberg]

Yeah, I'd take that patch for 1.9.1/1.9.2, and I think I can convince release-drivers to take it also.

Comment 2

[Justin Wood (:Callek)]

Attachment: take 1, no console message

Remember this is built on mozilla-1.9.2, and I chose this as the easiest to do method, (no warning spew).

If you would rather have a saner warning than no warning, r- and tell me and I'll do it.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

Requesting 1.9.2.x approval This is a very trivial change that basically silences warnings that are really correct (for Gecko 2) but unused on the 1.9.2 branch.

Comment 4

[Justin Wood (:Callek)]

For posterity, I'm adding "manifest" to this patch as well.

<Callek> bsmedberg-away: rs+ to add "manifest" to my list of ignored directives bug for branch? (so I don't have to re-request review)
<bsmedberg> Callek: rs+

Comment 5

[LegNeato]

Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

a=LegNeato for 1.9.2.9. Please land on mozilla-1.9.2 default.

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6801ef439dac

Comment 7

[Justin Wood (:Callek)]

Attachment: as landed

As landed.

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 463881 [details] [diff] [review]
as landed

Requesting 1.9.1.x approval This is a very trivial change that basically
silences warnings that are really correct (for Gecko 2) but unused on the 1.9.1
branch.

This applies cleanly on 1.9.1, and just landed on 1.9.2 without noticing any problems.

Comment 9

[Justin Wood (:Callek)]

Attachment: as landed.2

...and actually use the correct version of what [should have] landed the first time.

Comment 10

[LegNeato]

Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.12.

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 463882 [details] [diff] [review]
as landed.2

I missed 1.9.1.12's window, requesting 1.9.1.13 instead

Comment 12

[LegNeato]

Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.13. Please be sure to land it on mozilla-1.9.1 default, *not* the relbranch

Comment 13

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d

Comment 14

[Ginn Chen]

(In reply to comment #13)
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d

     1.7 +    else if (!strcmp(token, "binary-component") ||
     1.8 +             !strcmp(token, "interfaces") ||
     1.9 +             !strcmp(token, "component") ||
    1.10 +             !strcmp(token, "contract") ||
    1.11 +             !strcmp(token, "category")
    1.12 +             !strcmp(token, "manifest")){

missed || here.

Comment 15

[Justin Wood (:Callek)]

(In reply to comment #14)
> (In reply to comment #13)
> > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d
> 
>      1.7 +    else if (!strcmp(token, "binary-component") ||
>      1.8 +             !strcmp(token, "interfaces") ||
>      1.9 +             !strcmp(token, "component") ||
>     1.10 +             !strcmp(token, "contract") ||
>     1.11 +             !strcmp(token, "category")
>     1.12 +             !strcmp(token, "manifest")){
> 
> missed || here.

And yet, I *thought* I actually imported the fixed patch into my MQ for the 1.9.1 grrrrr. Thanks though.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e3791e439222