Closed Bug 576820 Opened 11 years ago Closed 10 years ago

Provide saner Error Console Spew (or none) when Firefox 4 manifest features are used.

Categories

(Toolkit :: Startup and Profile System, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .9-fixed
status1.9.1 --- .14-fixed

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file, 2 obsolete files)

For Firefox 3.6 and 3.5, I propose either silencing entirely, or doing a "Warning: ignoring manifest directive meant for future version of Firefox encountered" or some such error message.

I am willing to do the work, but just need a confirmation that it is wanted. If so, please confirm and assign to me.
Yeah, I'd take that patch for 1.9.1/1.9.2, and I think I can convince release-drivers to take it also.
Assignee: nobody → bugspam.Callek
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch take 1, no console message (obsolete) — Splinter Review
Remember this is built on mozilla-1.9.2, and I chose this as the easiest to do method, (no warning spew).

If you would rather have a saner warning than no warning, r- and tell me and I'll do it.
Attachment #456004 - Flags: review?(benjamin)
Attachment #456004 - Flags: review?(benjamin) → review+
Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

Requesting 1.9.2.x approval This is a very trivial change that basically silences warnings that are really correct (for Gecko 2) but unused on the 1.9.2 branch.
Attachment #456004 - Flags: approval1.9.2.8?
For posterity, I'm adding "manifest" to this patch as well.

<Callek> bsmedberg-away: rs+ to add "manifest" to my list of ignored directives bug for branch? (so I don't have to re-request review)
<bsmedberg> Callek: rs+
Comment on attachment 456004 [details] [diff] [review]
take 1, no console message

a=LegNeato for 1.9.2.9. Please land on mozilla-1.9.2 default.
Attachment #456004 - Flags: approval1.9.2.9? → approval1.9.2.9+
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6801ef439dac
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attached patch as landed (obsolete) — Splinter Review
As landed.
Attachment #456004 - Attachment is obsolete: true
Comment on attachment 463881 [details] [diff] [review]
as landed

Requesting 1.9.1.x approval This is a very trivial change that basically
silences warnings that are really correct (for Gecko 2) but unused on the 1.9.1
branch.

This applies cleanly on 1.9.1, and just landed on 1.9.2 without noticing any problems.
Attachment #463881 - Flags: approval1.9.1.12?
Attached patch as landed.2Splinter Review
...and actually use the correct version of what [should have] landed the first time.
Attachment #463881 - Attachment is obsolete: true
Attachment #463882 - Flags: approval1.9.1.12?
Attachment #463881 - Flags: approval1.9.1.12?
Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.12.
Attachment #463882 - Flags: approval1.9.1.12? → approval1.9.1.12+
Comment on attachment 463882 [details] [diff] [review]
as landed.2

I missed 1.9.1.12's window, requesting 1.9.1.13 instead
Attachment #463882 - Flags: approval1.9.1.13?
Attachment #463882 - Flags: approval1.9.1.12+ → approval1.9.1.12-
Comment on attachment 463882 [details] [diff] [review]
as landed.2

a=LegNeato for 1.9.1.13. Please be sure to land it on mozilla-1.9.1 default, *not* the relbranch
Attachment #463882 - Flags: approval1.9.1.13? → approval1.9.1.13+
(In reply to comment #13)
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d

     1.7 +    else if (!strcmp(token, "binary-component") ||
     1.8 +             !strcmp(token, "interfaces") ||
     1.9 +             !strcmp(token, "component") ||
    1.10 +             !strcmp(token, "contract") ||
    1.11 +             !strcmp(token, "category")
    1.12 +             !strcmp(token, "manifest")){

missed || here.
OS: Windows XP → All
(In reply to comment #14)
> (In reply to comment #13)
> > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/331cce3ce22d
> 
>      1.7 +    else if (!strcmp(token, "binary-component") ||
>      1.8 +             !strcmp(token, "interfaces") ||
>      1.9 +             !strcmp(token, "component") ||
>     1.10 +             !strcmp(token, "contract") ||
>     1.11 +             !strcmp(token, "category")
>     1.12 +             !strcmp(token, "manifest")){
> 
> missed || here.

And yet, I *thought* I actually imported the fixed patch into my MQ for the 1.9.1 grrrrr. Thanks though.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e3791e439222
You need to log in before you can comment on or make changes to this bug.