The default bug view has changed. See this FAQ.

"Firefox is already running, but is not responding" window has no icon

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Win32
--
trivial
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Andrés Delfino, Assigned: bbondy)

Tracking

({polish, regression})

Trunk
mozilla9
x86
Windows XP
polish, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-p5])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.6) Gecko/20100625 (CK-IBM) Firefox/3.6.6 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100704 Minefield/4.0b2pre

"Firefox is already running, but is not responding" window has no icon. See screenshot for details.

Reproducible: Always
(Reporter)

Comment 1

7 years ago
Created attachment 455946 [details]
Screenshot
(Reporter)

Updated

7 years ago
Version: unspecified → Trunk
(Reporter)

Updated

7 years ago
Keywords: regression
(Reporter)

Comment 2

7 years ago
This is a regression with respect to Firefox 3.6.6.
Jim, could this be a titlebar drawing regression?
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32

Comment 4

7 years ago
Don't see how that would cause something like this, it's caused by a hung process, which could be anything.
(Reporter)

Comment 5

7 years ago
Please note that I'm referring to the icon that should be at the left of the message, and not in the titlebar.
(Reporter)

Updated

7 years ago
Whiteboard: [polish-p3]
(Reporter)

Updated

7 years ago
Keywords: polish
Whiteboard: [polish-p3] → [polish-p5]

Updated

6 years ago
Depends on: 491947
(Assignee)

Updated

6 years ago
Assignee: nobody → netzen
(Assignee)

Comment 6

6 years ago
Created attachment 554415 [details] [diff] [review]
Patch for no icon

The problem was that we were using a confirm box with only an OK button when we didn't have a profile unlocker supplied at startup.
I now use an alert box with a warning icon in that case.
Attachment #554415 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 7

6 years ago
By the way it was showing an icon for me but it was the wrong icon (a question mark) and should be an alert as the patch does.

Comment 8

6 years ago
Comment on attachment 554415 [details] [diff] [review]
Patch for no icon

I'm guessing this needs (sub)moa.
Attachment #554415 - Flags: feedback?(benjamin)
Attachment #554415 - Flags: feedback?(benjamin) → feedback+

Comment 9

6 years ago
Comment on attachment 554415 [details] [diff] [review]
Patch for no icon

>-      flags =
>+      PRUint32 flags =
Since we're no longer changing the flags, can we make this const?

>-        nsIPromptService::BUTTON_TITLE_CANCEL * nsIPromptService::BUTTON_POS_0 +
>-        nsIPromptService::BUTTON_TITLE_IS_STRING * nsIPromptService::BUTTON_POS_1 +
>+        (nsIPromptService::BUTTON_TITLE_CANCEL * 
>+         nsIPromptService::BUTTON_POS_0) +
>+        (nsIPromptService::BUTTON_TITLE_IS_STRING * 
>+         nsIPromptService::BUTTON_POS_1) +
Why this change?
(Assignee)

Comment 10

6 years ago
> can we make this const?

Sure I'll submit an updated patch.

> Why this change?

The logic is the same, but I changed it to fix the line length >80. The parentheses are just for easier code readability.
(Assignee)

Comment 11

6 years ago
Created attachment 555826 [details] [diff] [review]
Patch for wrong icon v2

Added const to the flags variable.
Attachment #554415 - Attachment is obsolete: true
Attachment #555826 - Flags: review?(neil)
Attachment #554415 - Flags: review?(neil)

Updated

6 years ago
Attachment #555826 - Flags: review?(neil) → review+
http://hg.mozilla.org/mozilla-central/rev/84cf502e938a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
*headscratch*

Did you test the |if (aUnlocker)| code path, which still uses confirmEx()? And was it showing any icon?

I ask because the confirmEx() prompt should always be showing an icon (a question-mark icon). So it seems like there's still some bug lurking here as to how we're showing a prompt with _no_ icon...
With Firefox 6.0.1 on Windows 7 I get a prompt with a question icon, as expected.
Oh, this bug was originally reported against 3.6, and the prompting code's been completely rewritten since then. So unless the "no icon" prompt can be reproduced on a nightly, it's probably just an odd bug in the old code.

I checked Win7 in both Aero and Classic modes, and get icons in both cases.

False alarm! :)
(Assignee)

Comment 16

6 years ago
See Comment 6, and feedback+ from bsmedberg. The problem couldn't be reproduced with no icon but it was suggested to change to a warning icon instead of a question mark.
You need to log in before you can comment on or make changes to this bug.