Last Comment Bug 577058 - collectstats.pl --regenerate fails on PostgreSQL
: collectstats.pl --regenerate fails on PostgreSQL
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Reporting/Charting (show other bugs)
: 3.4
: All All
: -- normal (vote)
: Bugzilla 3.6
Assigned To: Max Kanat-Alexander
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-05 22:29 PDT by Max Kanat-Alexander
Modified: 2010-07-06 11:10 PDT (History)
1 user (show)
LpSolit: approval+
LpSolit: approval3.6+
mkanat: blocking3.6.2+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (460 bytes, patch)
2010-07-05 22:31 PDT, Max Kanat-Alexander
reed: review+
Details | Diff | Review

Description Max Kanat-Alexander 2010-07-05 22:29:45 PDT
Doing collectstats.pl --regenerate fails on PostgreSQL (and probably any non-MySQL database) because there's a SQL error that is coincidentally worked around by the DB::Mysql implementation of sql_to_days.
Comment 1 Max Kanat-Alexander 2010-07-05 22:31:08 PDT
Created attachment 456140 [details] [diff] [review]
v1

This adds a single space, to fix the problem. :-)
Comment 2 Reed Loden [:reed] (use needinfo?) 2010-07-05 23:02:24 PDT
Comment on attachment 456140 [details] [diff] [review]
v1

r=me by inspection.

Surprised nobody noticed this sooner, considering it should throw some type of SQL error.
Comment 3 Max Kanat-Alexander 2010-07-06 11:10:02 PDT
Yeah, I'm surprised as well. Well, --regenerate isn't that commonly used or known about, I suppose.

In any case, thanks for the review! :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified collectstats.pl
Committed revision 7283.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified collectstats.pl
Committed revision 7122.

Note You need to log in before you can comment on or make changes to this bug.