Closed
Bug 577058
Opened 14 years ago
Closed 14 years ago
collectstats.pl --regenerate fails on PostgreSQL
Categories
(Bugzilla :: Reporting/Charting, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
460 bytes,
patch
|
reed
:
review+
|
Details | Diff | Splinter Review |
Doing collectstats.pl --regenerate fails on PostgreSQL (and probably any non-MySQL database) because there's a SQL error that is coincidentally worked around by the DB::Mysql implementation of sql_to_days.
Flags: blocking3.6.2+
Assignee | ||
Comment 1•14 years ago
|
||
This adds a single space, to fix the problem. :-)
Comment 2•14 years ago
|
||
Comment on attachment 456140 [details] [diff] [review] v1 r=me by inspection. Surprised nobody noticed this sooner, considering it should throw some type of SQL error.
Attachment #456140 -
Flags: review?(reed) → review+
Updated•14 years ago
|
Flags: approval?
Flags: approval3.6?
Updated•14 years ago
|
Flags: approval?
Flags: approval3.6?
Flags: approval3.6+
Flags: approval+
Assignee | ||
Comment 3•14 years ago
|
||
Yeah, I'm surprised as well. Well, --regenerate isn't that commonly used or known about, I suppose. In any case, thanks for the review! :-) Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified collectstats.pl Committed revision 7283. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified collectstats.pl Committed revision 7122.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•