Closed Bug 577058 Opened 11 years ago Closed 11 years ago
.pl --regenerate fails on Postgre SQL
Doing collectstats.pl --regenerate fails on PostgreSQL (and probably any non-MySQL database) because there's a SQL error that is coincidentally worked around by the DB::Mysql implementation of sql_to_days.
This adds a single space, to fix the problem. :-)
Assignee: charting → mkanat
Status: NEW → ASSIGNED
Attachment #456140 - Flags: review?(reed)
Comment on attachment 456140 [details] [diff] [review] v1 r=me by inspection. Surprised nobody noticed this sooner, considering it should throw some type of SQL error.
Attachment #456140 - Flags: review?(reed) → review+
Yeah, I'm surprised as well. Well, --regenerate isn't that commonly used or known about, I suppose. In any case, thanks for the review! :-) Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified collectstats.pl Committed revision 7283. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified collectstats.pl Committed revision 7122.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.