Closed Bug 577130 Opened 10 years ago Closed 9 years ago
xmlparser should tell channels that it expects the content to be xml
this has been mentioned occasionally. basically when things go bad we trigger fun recursion trying to guess mime types....
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456176 - Flags: review?(jonas)
sorry, i thought someone compiled that... this compiles in my tree...
Comment on attachment 456231 [details] [diff] [review] proposal I'm not a module peer for this code, so I'm not the right person to review this.
Attachment #456231 - Flags: review?(hsivonen) → review?(peterv)
Comment on attachment 456231 [details] [diff] [review] proposal The comment mentions application/xml-dtd which is the right mimetype afaik, but you pass application/xml to SetContentType.
Attachment #456231 - Flags: review?(peterv) → review-
afaict we don't support that mime type. i can add it ...
I woudn't bother, nor would I put it in the comment....
Comment on attachment 463292 [details] [diff] [review] without -dtd comment >+ rv = NS_NewChannel(getter_AddRefs(channel), uri); >+ if (NS_FAILED(rv)) >+ return rv; NS_ENSURE_SUCCESS(rv, rv);
Attachment #463292 - Flags: review?(peterv) → review+
Comment on attachment 466981 [details] [diff] [review] NS_ENSURE_SUCCESS I don't want to take this change this late...
Attachment #466981 - Flags: approval2.0? → approval2.0-
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.