Bugzilla::Product::check_product() throws an error if you pass a product name which doesn't exist, letting the user know whether it's a valid product name or not. This is going to be fixed in Bugzilla 4.2 as part of bug 519835.
duplicates.cgi is also vulnerable, at least in 3.2.
Created attachment 456194 [details] [diff] [review] patch for 3.2 and 3.4, v1 Here is the patch for 3.2. I didn't want to create a new constant as it's for branches only.
Comment on attachment 456194 [details] [diff] [review] patch for 3.2 and 3.4, v1 This looks right. For newer branches you should just be able to use check().
(In reply to comment #3) > For newer branches you should just be able to use check(). For 3.6, I think so. But 3.4 has no custom check() method (which is needed to override the error message).
(In reply to comment #4) > For 3.6, I think so. But 3.4 has no custom check() method (which is needed to > override the error message). Ah, okay.
Comment on attachment 456194 [details] [diff] [review] patch for 3.2 and 3.4, v1 The same patch applies and works for 3.2 and 3.4.
It will be ready on time for the next releases.
I finally checked in bug 519835 in 4.0, so Bugzilla 3.7.3 doesn't need to be fixed in this bug. duplicates.cgi was already fixed since Bugzilla 3.6rc1 thanks to bug 514970. Both request.cgi and duplicates.cgi were affected since Bugzilla 2.17.1.
Created attachment 456259 [details] [diff] [review] patch for 3.6, v1 Bugzilla 3.6 has a custom check() method in Product.pm, which throws the appropriate error. So we can use it here.
Comment on attachment 456259 [details] [diff] [review] patch for 3.6, v1 Yeah, obviously correct. :-)
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/ modified request.cgi Committed revision 7159. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.4/ modified duplicates.cgi modified request.cgi modified Bugzilla/Product.pm Committed revision 6773. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.2/ modified duplicates.cgi modified request.cgi modified Bugzilla/Product.pm Committed revision 6394.
Security advisory sent, unlocking bug.
or
