577206 - vp8 warning: implicit declaration of function ‘mach_task_self’

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[timeless]

media/libvpx/vp8/

decoder/threading.c: In function ‘vp8_decoder_create_threads’:
decoder/threading.c:406: warning: implicit declaration of function ‘mach_task_self’

Comment 1

[timeless]

Attachment: patch

Comment 2

[timeless]

i've filed a bug for upstream:
http://code.google.com/p/webm/issues/detail?id=122

Comment 3

[Michael Kohler [:mkohler]]

Attachment: Patch v2

Comment 4

[Michael Kohler [:mkohler]]

Attachment: Patch v3

Comment 5

[Timothy B. Terriberry (:derf)]

Comment on attachment 456292 [details] [diff] [review]
Patch v3

>+#ifdef __APPLE__
>+#include <mach/mach_init.h>
>+#endif

This probably belongs in the existing __APPLE__ block in threading.h, since the macros that actually invoke mach_task_self are defined there. Also, the manpage suggests that the correct header to include is <mach/mach_traps.h>. Why did you pick mach_init.h?

Comment 6

[timeless]

I think it was something like this:
http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/mach_task_self.html

the documentation from apple is painful to find/read/understand.

Comment 7

[Michael Kohler [:mkohler]]

Merged: http://review.webmproject.org/362

Comment 8

[Michael Kohler [:mkohler]]

Checked in as part of changeset 012c64c66def.. http://hg.mozilla.org/mozilla-central/diff/012c64c66def/media/libvpx/vp8/decoder/threading.c#l1.20

-> FIXED