Closed Bug 577206 Opened 12 years ago Closed 12 years ago

vp8 warning: implicit declaration of function ‘mach_task_self’

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: mkohler)

References

()

Details

Attachments

(1 file, 2 obsolete files)

media/libvpx/vp8/

decoder/threading.c: In function ‘vp8_decoder_create_threads’:
decoder/threading.c:406: warning: implicit declaration of function ‘mach_task_self’
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456234 - Flags: review?(chris)
i've filed a bug for upstream:
http://code.google.com/p/webm/issues/detail?id=122
Assignee: timeless → michaelkohler
Attached patch Patch v2 (obsolete) — Splinter Review
Attachment #456234 - Attachment is obsolete: true
Attachment #456278 - Flags: review?(tterribe)
Attachment #456234 - Flags: review?(chris)
Attached patch Patch v3Splinter Review
Attachment #456278 - Attachment is obsolete: true
Attachment #456292 - Flags: review?(tterribe)
Attachment #456278 - Flags: review?(tterribe)
Comment on attachment 456292 [details] [diff] [review]
Patch v3

>+#ifdef __APPLE__
>+#include <mach/mach_init.h>
>+#endif

This probably belongs in the existing __APPLE__ block in threading.h, since the macros that actually invoke mach_task_self are defined there. Also, the manpage suggests that the correct header to include is <mach/mach_traps.h>. Why did you pick mach_init.h?
Attachment #456292 - Flags: review?(tterribe) → review-
I think it was something like this:
http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/mach_task_self.html

the documentation from apple is painful to find/read/understand.
Checked in as part of changeset 012c64c66def.. http://hg.mozilla.org/mozilla-central/diff/012c64c66def/media/libvpx/vp8/decoder/threading.c#l1.20

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.