Closed Bug 577226 Opened 14 years ago Closed 6 years ago

Make "suggestions" work for quick search

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: i.drugoy, Unassigned)

References

Details

Attachments

(1 file)

InstantFox suggestions screenshot
91.37 KB, image/png
Details
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100706 Firefox/3.6.6 YB/3.5.1 Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100706 Currently, suggestions work for search bar and on some sites. When you make a quick search keyword to easily access any search engine using address bar - suggestions don't work there. Reproducible: Always Steps to Reproduce: 1. Create a quick search bookmark and set a keyword for it (for example "g" to search in Google). 2. Type "g moz" and don't hit enter. Actual Results: Smart Location Bar searches through the browser history for "g moz". Expected Results: Suggestions for "moz" search word in Google, e.g.: mozilla firefox, mozilla, mozart, etc. Address bar should recognize when the user enters a quick search keyword and should access the search engine to get suggestions from it and display them to the user.
This might be a bug from the switch to tab landing.
Do you mean it ever worked before?
I think we'll have to have blair's feedback here as I want to say, yeah... it worked. If that is the case that maybe there is some kind of change along the way that would have done it. If so, my first guess was just the last switch to tab updates.
where is blair's feedback?
why the bug is still unconfirmed? I filled it a week ago.
someone confirm the bug, ffs?
I don't remember this ever happening, might have been in one of your addons, Dale. I think it was supposed to be part of taskfox, though. Anyway, it would be a great addition.
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
(In reply to comment #7) > I don't remember this ever happening, might have been in one of your addons, > Dale. I think it was supposed to be part of taskfox, though. Anyway, it would > be a great addition. Addon's no, I haven't used Taskfox only but once, I was thinking suggestions means matches from history, bookmarks, etc.
Status: RESOLVED → UNCONFIRMED
Resolution: WONTFIX → ---
Depends on: 579716
(In reply to comment #4) > where is blair's feedback? Blair's feedback was delayed because he was on holiday ;) AFAIK, this has never worked (so its no regression from switch-to-tab). It seems like it might be nice to have (I'd like to see an overhaul of quicksearches in general), though I'd be worried about crowding the results. Note, however: This could only be done for search engines with keywords, not for bookmarks with keywords. Only search engines have information about how to retrieve suggestions. Would like some UX input here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to comment #9) > (In reply to comment #4) > > where is blair's feedback? > > Blair's feedback was delayed because he was on holiday ;) > > AFAIK, this has never worked (so its no regression from switch-to-tab). It > seems like it might be nice to have (I'd like to see an overhaul of > quicksearches in general), though I'd be worried about crowding the results. > > Note, however: This could only be done for search engines with keywords, not > for bookmarks with keywords. Only search engines have information about how to > retrieve suggestions. > > Would like some UX input here. could you please assign it to someone? or it will be totally forgotten for a few years more
(In reply to comment #10) > could you please assign it to someone? or it will be totally forgotten for a > few years more It only makes sense to assign to someone if that someone is actively working on it (or knows for certain they'll be the one to work on it, and no one else should). If someone wants to step up and make a patch, then great, and it can be assigned to them. It won't be forgotten, but it does depend on the available time of anyone able to work on it. Personally, I wouldn't have time to work on this until after 4.0 (at the very earliest).
blocking2.0: --- → ?
Severity: normal → major
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
OS: Windows 7 → All
Version: unspecified → Trunk
Hardware: x86 → x86_64
probably a good way to fix this bug - will be to take part of the code from extensions like Omnibar ( https://addons.mozilla.org/ru/firefox/addon/8823/ ) [ just take a look how it works: https://addons.mozilla.org/img/uploads/previews/full/26/26085.png?modified=1221648048 ] or Foobar ( https://addons.mozilla.org/ru/firefox/addon/84985/ ) [this is how this ext is working: https://addons.mozilla.org/img/uploads/previews/full/43/43342.png ]
(In reply to comment #11) > It only makes sense to assign to someone if that someone is actively working on And just like I said - the bug is staying ignored for more than 1.5 months already, and it's status is still "New".
(In reply to comment #13) > And just like I said - the bug is staying ignored for more than 1.5 months > already, and it's status is still "New". So? That just means no one has time to work on it right now. There are other priorities. Bugs aren't fixed based on the order they are submitted. And this isn't a critical bug/regression, so wouldn't block a release on an older (stable) branch. Pretty sure it wouldn't be accepted as a backport to those branches either, given its adding something new.
Severity: major → normal
blocking1.9.1: ? → ---
blocking1.9.2: ? → ---
Hardware: x86_64 → All
Indeed, as good a suggestion as this is, it's not a blocker.
blocking2.0: ? → -
almost a year has passed since then. I believe this feature doesn't require a HUGE amount of work, so please mark it tracking for any of Fx version. Or it will be ignored for years more.
tracking-firefox5: --- → ?
tracking-firefox6: --- → ?
tracking-firefox7: --- → ?
that's not how the tracking flags are to be used (they are only used on FIXED bugs)...
tracking-firefox5: ? → ---
tracking-firefox6: ? → ---
tracking-firefox7: ? → ---
Well, sorry for that, but I don't have enough rights to change this bug's "blocking 2.0" status from "-" to "?". Could you do that, please? Almost a year has passed, since it was rejected as a blocking bug, due to upcoming Fx 4 release. Now there is even a new system of development-channels, so the situations now and then are completely different and I hope the bug is worth reconsidering it's importance.
(In reply to comment #18) > Well, sorry for that, but I don't have enough rights to change this bug's > "blocking 2.0" status from "-" to "?". Could you do that, please? Almost a year > has passed, since it was rejected as a blocking bug, due to upcoming Fx 4 > release. 2.0 has shipped (Firefox 4) and it wouldn't get any new features like this. > Now there is even a new system of development-channels, so the situations now > and then are completely different and I hope the bug is worth reconsidering > it's importance. There's no concept of blocking bugs anymore. What gets in, gets in. Someone just needs to do the work.
(In reply to comment #19) > 2.0 has shipped (Firefox 4) and it wouldn't get any new features like this. I didn't mean exactly Fx 4. > There's no concept of blocking bugs anymore. What gets in, gets in. > Someone just needs to do the work. Is there any way now to somehow bring developers' attention to the particular bug?
(In reply to comment #20) > I didn't mean exactly Fx 4. The blocking2.0 flag is specifically for Firefox 4. > Is there any way now to somehow bring developers' attention to the particular > bug? Apart from filing it, not really. You could request that it be looked at in the appropriate newsgroup, but that's about it.
bugspam (In reply to comment #21) > Apart from filing it, not really. You could request that it be looked at in > the appropriate newsgroup, but that's about it. That is really sad, so now I leave my hopes to see this built-in Fx. My new hope is that someone's gonna write an extension with that feature. Actually it's a good point to regard Firefox as just an engine, that supports extensions, which make it a browser. This idea explains why mozilla is trying to cut some features users like and why the refuse to interact with users themselves: their target is extensions' developers. More proof is that Firefox without it's extensions can hardly be called a usable browser.
In the comments to this article: http://autonome.wordpress.com/2011/06/08/extensibly-awesome/ someone gave a link: https://addons.mozilla.org/en-US/firefox/addon/bzapi/ to the jetpack-addon based on the idea described in the article. Can't all this help to fix this bug?
Anyone keen to see progress here is welcome to create a patch and submit it for review. See for example https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch. Nagging here in bugzilla is not helpful.
Was my question a nagging? I just saw an extension which does what should this bug do. The extension is written by some mozdev, so maybe he just didn't see this bug. Or I might just be wrong and you can't just transplant the code from the extension to the patch for this bug. I'm not a programmer at all, I'm just asking, not nagging. I nagged on IRC, not in bugzilla.
This extension: https://addons.mozilla.org/firefox/addon/instantfox/?src=search partially fixes this bug.
Actually, this extension seems to fix this bug completely, not partially.
No, not at all. It is a quick hack and displays the suggested links in a web page, not in the address bar where you want them.
Uhm, no, it shows them in the address bar actually. There is something wrong on your side I think. Take a look at the screenshot in the attachment.
We can't do this with bookmark keywords, if bug 648398 should convert bookmark keywords to custom search engines, then maybe we could do something, but still we need a suggestions url to fetch remote suggestions and we lack that data. Probably the best fit could be bug 782557.
Resolution: DUPLICATE → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: