577415 - Allow positional parameters for XML-RPC

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Max Kanat-Alexander]

The Testopia WebService uses positional parameters, and the XML-RPC in Bugzilla 3.6 doesn't allow this.

JSON-RPC will always require positional parameters, but it's possible that we can work around things for 3.6 for XML-RPC.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, does this fix it for you, ghendricks?

Comment 2

[Greg Hendricks]

Comment on attachment 456379 [details] [diff] [review]
v1

I still get an error but it is coming from Login::CGI: Fault: Client Can't use string ("1") as a HASH ref while "strict refs" in use at Bugzilla/Auth/Login/CGI.pm line 45.

Here is my call: $soapresult = $proxy->call('Environment.get_runs', 1);

Comment 3

[Greg Hendricks]

Comment on attachment 456379 [details] [diff] [review]
v1

+    $params = {} if !ref $params eq 'HASH';

should be 

+    $params = {} if ref $params ne 'HASH';

Then it works. :)

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Oh right, duh. :-) Thanks!

Comment 5

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7305.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7297.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7125.