Allow positional parameters for XML-RPC

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
WebService
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 3.6
Bug Flags:
approval +
approval4.0 +
approval3.6 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
541 bytes, patch
Greg Hendricks
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
The Testopia WebService uses positional parameters, and the XML-RPC in Bugzilla 3.6 doesn't allow this.

JSON-RPC will always require positional parameters, but it's possible that we can work around things for 3.6 for XML-RPC.
(Assignee)

Comment 1

7 years ago
Created attachment 456379 [details] [diff] [review]
v1

Okay, does this fix it for you, ghendricks?
Assignee: webservice → mkanat
Status: NEW → ASSIGNED
Attachment #456379 - Flags: review?(ghendricks)

Comment 2

7 years ago
Comment on attachment 456379 [details] [diff] [review]
v1

I still get an error but it is coming from Login::CGI: Fault: Client Can't use string ("1") as a HASH ref while "strict refs" in use at Bugzilla/Auth/Login/CGI.pm line 45.

Here is my call: $soapresult = $proxy->call('Environment.get_runs', 1);

Comment 3

7 years ago
Comment on attachment 456379 [details] [diff] [review]
v1

+    $params = {} if !ref $params eq 'HASH';

should be 

+    $params = {} if ref $params ne 'HASH';

Then it works. :)
Attachment #456379 - Flags: review?(ghendricks) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 456473 [details] [diff] [review]
v2

Oh right, duh. :-) Thanks!
Attachment #456379 - Attachment is obsolete: true
Attachment #456473 - Flags: review?(ghendricks)

Updated

7 years ago
Attachment #456473 - Flags: review?(ghendricks) → review+

Updated

7 years ago
Flags: approval?
(Assignee)

Updated

7 years ago
Flags: approval?
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 5

7 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7305.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7297.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7125.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.