577426 - mozilla-central xulrunner nightlies broken since xpcom manifest landing

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Seems to be all platforms, here's a linux example from
http://tinderbox.mozilla.org/showlog.cgi?log=XULRunner/1278496950.1278499956.8621.gz

/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp: In function ‘nsresult InitEmbedding_Impl(JNIEnv*, _jobject*, _jobject*, _jobject*)’:
/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp:95: error: ‘XRE_InitEmbedding’ was not declared in this scope
/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp: In function ‘_jobject* Java_org_mozilla_xpcom_internal_XPCOMImpl_getComponentManager(JNIEnv*, _jobject*)’:
/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp:238: error: incomplete type ‘nsIComponentManager’ used in nested name specifier
/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp:238: error: expected primary-expression before ‘int’
/builds/slave/mozilla-central-linux-xulrunner/build/extensions/java/xpcom/src/nsJavaInterfaces.cpp:238: error: expected `)' before ‘int’

Broke in this change window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=82edf5bd1abe&tochange=c173731c9d90

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Yeah, part of this: http://hg.mozilla.org/mozilla-central/rev/1e41bf320ea0

Comment 2

[Benjamin Smedberg]

Attachment: Disable JavaXPCOM by default

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 457570 [details] [diff] [review]
Disable JavaXPCOM by default

Ashes to ashes, JNI thunking to dust.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/871a801486f3

Comment 6

[Daniel Kirsch]

Thanks for the fix. However I only see Linux and Mac builds. What about Windows?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

There's a new error in the win32 build, eg
  http://tinderbox.mozilla.org/showlog.cgi?log=XULRunner/1280224959.1280232071.28289.gz
Please file a separate bug for that.

Comment 8

[Daniel Kirsch]

(In reply to comment #7)
> Please file a separate bug for that.

Done. See bug 582559