577444 - Icons in the tab bar overlap the "tab" itself

Status: RESOLVED DUPLICATE of bug 574654

(Firefox :: Tabbed Browser, defect)

Description

[Anthony Williams]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:2.0b1) Gecko/20100630 Firefox/4.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:2.0b1) Gecko/20100630 Firefox/4.0b1

With many tabs open, each tab is small. The current tab does not then have room for both the favicon and the "close tab" icon, so they overlap the tab itself.

Reproducible: Always

Steps to Reproduce:
1. Open lots of tabs

Actual Results:  
On the "current tab" the favicon and close icon overlap the edges of the tab

Expected Results:  
Expand the tab to fit the favicon and the close icon.

Comment 1

[Anthony Williams]

Attachment: Screenshot showing overlapping icons

Comment 2

[Jo Hermans]

Firefox 4.0 seems to have removed the browser.tabs.tabMinWidth preference in bug 574654.

Comment 3

[Dão Gottwald [:dao]]

Please report this to the theme author. He's probably setting a min-height which he shouldn't, see also bug 571944.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Please report this to the theme author. He's probably setting a min-height
> which he shouldn't, see also bug 571944.

s/min-height/min-width/

If you're using the default theme, check whether you set a min-width there.

Comment 5

[Anthony Williams]

(In reply to comment #4)
> If you're using the default theme, check whether you set a min-width there.

I'm using the default theme. I'm not aware of having set a min-width. How would I check whether or not I have?

Comment 6

[Dão Gottwald [:dao]]

It would be in userChrome.css or somewhere in Stylish. Some other add-on could be causing this too.

Comment 7

[Anthony Williams]

(In reply to comment #6)
> It would be in userChrome.css or somewhere in Stylish. Some other add-on could
> be causing this too.

How could I tell? This happens in safe mode too.

Comment 8

[Dão Gottwald [:dao]]

Try a new profile, safe mode in beta 1 is broken.

Comment 9

[Anthony Williams]

(In reply to comment #8)
> Try a new profile, safe mode in beta 1 is broken.

OK, it doesn't happen on a new profile. It still needs fixing though for people upgrading. Everything works in FF3.6.6.

FF4 disables all my extensions as incompatible. When I upgrade "for real" I don't want to have to rebuild my profile from scratch; I want to keep my bookmarks, saved passwords, and other settings, and upgrade my extensions *without* hitting problems like this. 

Incidentally, I checked in about:config.  browser.tabs.tabMinWidth was set to 30. Setting it to 50 fixes the problem. It seems like this should be updated on upgrade, or ignored if its too small.

I must have set this with an extension, but I don't remember doing so. I do like the small tabs that result from it when I have a lot open, rather than the huge tabs I get with the default profile from FF4.

Comment 10

[Jo Hermans]

(In reply to comment #9)
> FF4 disables all my extensions as incompatible. When I upgrade "for real" I
> don't want to have to rebuild my profile from scratch; I want to keep my
> bookmarks, saved passwords, and other settings, and upgrade my extensions
> *without* hitting problems like this. 

That's why it's a beta ... Mozilla isn't responsible for those add-ons, the authors of these add-ons should have tested and converted their add-ons. But many of them will wait for the final release of 4.0. Again, that's why it's a beta !

Comment 11

[Anthony Williams]

(In reply to comment #10)
> (In reply to comment #9)
> > FF4 disables all my extensions as incompatible. When I upgrade "for real" I
> > don't want to have to rebuild my profile from scratch; I want to keep my
> > bookmarks, saved passwords, and other settings, and upgrade my extensions
> > *without* hitting problems like this. 
> 
> That's why it's a beta ... Mozilla isn't responsible for those add-ons, the
> authors of these add-ons should have tested and converted their add-ons. But
> many of them will wait for the final release of 4.0. Again, that's why it's a
> beta !

But even if I uninstall all my addons, that won't change the fact that browser.tabs.tabMinWidth is now set in my profile for FF3.6. This is a FF property, so the upgrade should handle it (even if it just removes the setting from the profile or ignoring it). If I install an addon on FF4 and it causes problems, that's a different issue.

I realise this is a beta release. I'm reporting a problem so that it will hopefully be fixed before there's a final release. In the mean time, I can continue using FF 3.6.

Comment 12

[Dão Gottwald [:dao]]

browser.tabs.tabMinWidth is going away.