Closed Bug 577480 Opened 14 years ago Closed 14 years ago

"New window" button not working when removing and adding it back on a toolbar

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
minor

Tracking

()

RESOLVED DUPLICATE of bug 540838

People

(Reporter: ahoza, Unassigned)

Details

(Keywords: regression)

User-Agent:       Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100708 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100708 Minefield/4.0b2pre

Nothing happens when clicking on "New Window" button after removing and adding it back to a toolbar through Toolbars->Customize.

Reproducible: Always

Steps to Reproduce:
1.Open Toolbars->Customize
2. Drag and drop "New Window" button to  Navigation Toolbar.
3. Close "Customize Toolbar" dialog and click "New Window" button on Navigation Toolbar. A new window is opened.
4. Open Toolbars->Customize and drag "New Window" button back to "Customize Toolbar" dialog.
5. Drag it once again on Navigation toolbar and close "Customize Toolbar" dialog.
6. Click on "New Window" button in Navigation toolbar  
Actual Results:  
Nothing happens.

Expected Results:  
A new browser window opens.
Confirming this bug using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre. I don't see any relevant errors in the console. Changing to all and adding regression keyword.
Status: UNCONFIRMED → NEW
Component: General → Toolbars
Ever confirmed: true
QA Contact: general → toolbars
OS: Windows XP → All
Version: unspecified → Trunk
Turns out I see the same issue using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8 (.NET CLR 3.5.30729), so perhaps this has been an issue all along.
Regression Window in m-c build:
works:
http://hg.mozilla.org/mozilla-central/rev/0d300ab7a8cf
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20081203 Firefox/3.2a1pre ID:20081203041857
Fails:
http://hg.mozilla.org/mozilla-central/rev/169e8eb751a7
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20081204 Firefox/3.2a1pre ID:20081204034432
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0d300ab7a8cf&tochange=169e8eb751a7

Regression Window in 1.9.1branch
Works:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/18398e0350cd
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20081209 Shiretoko/3.1b3pre ID:20081209035944
Fails:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9269759f81b7
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20081210 Shiretoko/3.1b3pre ID:20081210161531
Pushlog:
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=18398e0350cd&tochange=9269759f81b7

And I confirmed in local build, Landing of Bug 407725 causes the problem.
Blocks: 407725
Probably a duplicate of Bug 540838. Does the patch there also fix this?
(In reply to comment #4)
> Probably a duplicate of Bug 540838. Does the patch there also fix this?
Yes, the patch of Bug 540838 resolve the issue,
So, I make change status to Resolved Duplicate.
No longer blocks: 407725
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.