Closed Bug 577514 Opened 10 years ago Closed 10 years ago
Remove redundant pref-offline UI which was commented out since 2001
In preferences.xul I see this comment: <!-- commented out until bug 82487 is fixed <treeitem id="offlineItem" label="&offline.label;" helpTopic="mail_prefs_offline" url="chrome://communicator/content/pref/pref-offline.xul"/> --> However bug 82487 is long since fixed. Meanwhile the UI for this pref has moved to Mail&Newsgroups -> Offline&Disk Space. To quote Bug 221734 comment 19: > - pref-offline.xul was created by me in bug 221736 to move some mailnews prefs > to the mailnews section where they belong. > - The offline startup prefs were left in place, since they are not mailnews > specific. > - The offline startup prefs were commented out pending the fix for bug 82487. > They still are where they have always been, so that we now have a duplication > of the prefs. I propose to remove the communicator pref-offline UI since: 1. It's the old XPFE <panel> so would need to be totally rewritten anyway. 2. Commented out since 2001 and nobody noticed in the intervening 9 years, or at least enough to care. 3. There is functional UI in the prefwindow that deals with this pref anyway.
Comment on attachment 456465 [details] [diff] [review] Patch v1.0 remove useless files. r=me
Attachment #456465 - Flags: review?(iann_bugzilla) → review+
Attachment #456465 - Flags: superreview?(neil) → superreview+
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/cf1f206abe6a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.