Closed Bug 577588 Opened 15 years ago Closed 15 years ago

xt/search.t is sometimes not properly translating values

Categories

(Bugzilla :: Testing Suite, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Sometimes a <2> is left in the value when passing it to the database, in xt/search.t. This wasn't causing any trouble on MySQL, but PostgreSQL is more strict and threw an error. This is actually a bug in the search test, and needs to be fixed in general.
Blocks: pg-xt-search
Target Milestone: --- → Bugzilla 4.2
Attached patch v1Splinter Review
Okay, this fixes it in various ways for various different fields. I also added a check so that I can't re-introduce this bug into the test.
Assignee: testing → mkanat
Status: NEW → ASSIGNED
Attachment #456513 - Flags: review+
Flags: approval+
The patch also applies on 4.0, and it fixes a bug in the test, so I think it should go there too.
Flags: approval4.0+
Target Milestone: Bugzilla 4.2 → Bugzilla 4.0
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified xt/lib/Bugzilla/Test/Search.pm modified xt/lib/Bugzilla/Test/Search/Constants.pm modified xt/lib/Bugzilla/Test/Search/FieldTest.pm Committed revision 7313. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified xt/lib/Bugzilla/Test/Search.pm modified xt/lib/Bugzilla/Test/Search/Constants.pm modified xt/lib/Bugzilla/Test/Search/FieldTest.pm Committed revision 7300.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: