577622 - widget example in tutorial doesn't work

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Gordon P. Hemsley [:GPHemsley]]

The example in the tutorial doesn't actually work, and I'm told it has something to do with the way that the URL is specified.

Here's the problematic code:
  var widgets = require("widget");

  widgets.add(widgets.Widget({
    label: "Visit The Mozilla Website",
	image: "http://www.mozilla.org/favicon.ico",
	onClick: function(event) {
      require("tabs").open(require("url").URL("http://www.mozilla.org"));
    }}));

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: v1 - fix code error and indentation

fix the code, as well as the indentation probs.

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

(In reply to comment #1)
> Created an attachment (id=456640) [details]
> v1 - fix code error and indentation
> 
> fix the code, as well as the indentation probs.

In case there's any doubt, I can confirm that the new code works.

Comment 3

[Piotr Zalewa [:zalun]]

github has a nice commit links: http://github.com/autonome/FlightDeck/commit/51d4caebde282507e9af23f219cbd5b4cb879139

pulled and pushed to http://github.com/zalun/FlightDeck

PS.
Please use a separate branch for every fix as I had to pull two fixes at once.
I will write a small docs about branching in git