577851 - config.cgi does not work in 3.4.7

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frank Becker]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; de-de) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16
Build Identifier: 3.4.7

After upgrade from 3.4.6 to 3.4.7  the configuration  load did not.

Error: Can't locate object method "match" via package "Bugzilla::Component" at Bugzilla/Product.pm line 138.

Reproducible: Always

Steps to Reproduce:
1. try to get the config with ...config.cgi?ctype=rdf

Actual Results:  
Error:

Can't locate object method "match" via package "Bugzilla::Component" at Bugzilla/Product.pm line 138.

Expected Results:  
xml with the configuration

Comment 1

[Frédéric Buclin]

We indeed regressed it, I think due to bug 553255. This is a major regression, so I will take it for 3.4.8.

Comment 2

[Frédéric Buclin]

Bugzilla 3.6 and newer are not affected. 3.4.7 only.

Comment 3

[Max Kanat-Alexander]

The simplest fix is to stop making it use preload on 3.4, I think.

I'm surprised nobody reported this before, since the code was live on bmo and was the backend of BzAPI.

Comment 4

[Max Kanat-Alexander]

A simple test that just tries to load config.cgi would probably be good.

Comment 5

[Frank Becker]

(In reply to comment #1)
> We indeed regressed it, I think due to bug 553255. This is a major regression,
> so I will take it for 3.4.8.

Yes, when I comment the line

 Bugzilla::Product::preload($vars->{'products'}); 

I get the configuration.

Comment 6

[Frédéric Buclin]

(In reply to comment #4)
> A simple test that just tries to load config.cgi would probably be good.

We have one for a very long time. But test_config.cgi only loads the JS version of the script, not the RDF one (I would have to check, but I'm not sure Selenium is able to parse the output correctly).

Comment 7

[Frédéric Buclin]

Oh, wow, no need for the RDF template. The JS one is broken too, so my test was supposed to catch the problem.

Comment 8

[Frédéric Buclin]

OK, I don't get it. If I remove this line from test_config.t:

 set_parameters($sel, { "User Authentication" => {"requirelogin-on" => undef} });

then the script fails, as expected (same error as in comment 0). But if I leave it, then the script passes, and config.cgi doesn't crash?!

Comment 9

[Frédéric Buclin]

Attachment: patch, v1

Backout bug 553255 for 3.4.x.

Comment 10

[Max Kanat-Alexander]

Comment on attachment 456727 [details] [diff] [review]
patch, v1

This works just as well as my other patch, but I suppose it is more reliable and simple as a fix?

Comment 11

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/3.4/
modified config.cgi
Committed revision 6765.