577854 - URL field header caption does not link to field value description (confusingly links to actual URL)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Thomas D. (:thomas8)]

STR

1 Fill out a bug report
2 Click on the field header of any other field to retrieve field descriptions / information about accepted values etc. E.g., click on "Status" to get to https://bugzilla.mozilla.org/page.cgi?id=fields.html#status (A bug's life cycle, with field explanations)
3 Now click on URL field header

Actual result

1) URL field header unexpectedly links to the URL field value (opens the URL)
2) Missing information about URL field at https://bugzilla.mozilla.org/page.cgi?id=fields.html#URL

Expected result

1) URL field header should link to information about URL field (like any other field header/caption):
2) There should be information about URL field at https://bugzilla.mozilla.org/page.cgi?id=fields.html#URL

Comment 1

[Thomas D. (:thomas8)]

The link on the URL field header is superfluous as we also linkify the actual URL value string.

Comment 2

[Frédéric Buclin]

Will be fixed by bug 575211.

Comment 3

[Max Kanat-Alexander]

  The "field-label in show_bug" patch will only go into 4.2, though. I think it would be reasonable to do something about this for 3.6 and 4.0.

Comment 4

[Max Kanat-Alexander]

  Oh, actually, only 4.0, because 3.6 doesn't have a description for that field.

Comment 5

[Matt Selsky [:selsky]]

Attachment: Link URL field caption to description, v1

Comment 6

[Max Kanat-Alexander]

Comment on attachment 575820 [details] [diff] [review]
Link URL field caption to description, v1

Review of attachment 575820 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Probably would also be cooler to use field-label.html.tmpl at some point, but it should support accesskeys, also.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 575820 [details] [diff] [review]
Link URL field caption to description, v1

Oh wait, I'm sorry. You actually have to use field-label.html.tmpl. Otherwise you don't get hover-help.

Comment 8

[Matt Selsky [:selsky]]

Attachment: Link URL field caption to description, v2

I've added accesskey support to field-label.html.tmpl.  However "u" seems to be a reserved access key on Firefox, Safari, and Chrome.  Along with "a" and "s".  Do these keys work on your platform/browser?

Comment 9

[Max Kanat-Alexander]

(In reply to Matt Selsky from comment #8)
> Created attachment 577187 [details] [diff] [review] [diff] [details] [review]
> Link URL field caption to description, v2
> 
> I've added accesskey support to field-label.html.tmpl.  However "u" seems to
> be a reserved access key on Firefox, Safari, and Chrome.  Along with "a" and
> "s".  Do these keys work on your platform/browser?

  Ah, good question. If it's really a problem, we should fix it in a separate bug.

Comment 10

[Max Kanat-Alexander]

Comment on attachment 577187 [details] [diff] [review]
Link URL field caption to description, v2

Review of attachment 577187 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks! :-)

Comment 11

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/field-label.html.tmpl
Committed revision 8032.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/field-label.html.tmpl
Committed revision 7975.

Comment 12

[Thomas D. (:thomas8)]

Thank you for fixing this! :)