Closed Bug 577859 Opened 15 years ago Closed 15 years ago

Update SeaMonkey package-manifest.in files with new *.manifest files

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-seamonkey2.1 a3+)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.1a3
Tracking Flags:
Tracking Status
blocking-seamonkey2.1 --- a3+

People

(Reporter: iannbugzilla, Assigned: kairo)

References

Details

Attachments

(2 files, 1 obsolete file)

first step: fix Linux (at least) [checked in]
11.29 KB, patch
Callek
: review+
Details | Diff | Splinter Review
second step: fix Windows
826 bytes, patch
Callek
: review+
Details | Diff | Splinter Review
With changes from bug 575740 and its blockers the package-manifest.in files need updating to reflect all the new manifest files that have been introduced.
You just need this for SeaMonkey - I did Thunderbird once we got the static builds green and I was doing the initial setup for them (assuming at the time that they would run, but as my last comment on bug 575740 shows I still need to come up with a fix for that).
Product: MailNews Core → SeaMonkey
QA Contact: build-config → build-config
Summary: Update comm-central package-manifest.in files with new *.manifest files → Update SeaMonkey package-manifest.in files with new *.manifest files
blocking-seamonkey2.1: --- → a3+
Depends on: 576900
Attached patch first step: fix Linux (at least) (obsolete) — — Splinter Review
This patch fixes everything I could find in Linux package-compare - there might be some things in Mac and/or Windows that are still missing, but it's easier to find out about those when the majority of cases is out of the way.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #456764 - Flags: review?(bugspam.Callek)
Erm, forgot to s/bin/@BINPATH@/ in the package manifest.
Attachment #456764 - Attachment is obsolete: true
Attachment #456766 - Flags: review?(bugspam.Callek)
Attachment #456764 - Flags: review?(bugspam.Callek)
Comment on attachment 456766 [details] [diff] [review] first step: fix Linux (at least) [checked in] Mostly an rs+. But I did skim that the lines look good; did not actually compare vs the package-compare output though. If you'd prefer that I do the compare itself I'll do so just will be a longer turnaround.
Attachment #456766 - Flags: review?(bugspam.Callek) → review+
(In reply to comment #4) > Comment on attachment 456766 [details] [diff] [review] > first step: fix Linux (at least) a=me too
Comment on attachment 456766 [details] [diff] [review] first step: fix Linux (at least) [checked in] Pushed as http://hg.mozilla.org/comm-central/rev/39e2a272c3de - let's see how far that takes us :)
Attachment #456766 - Attachment description: first step: fix Linux (at least) → first step: fix Linux (at least) [checked in]
Mac looks good in terms of manifests, the Windows compare-locales brought up one more, though, which is fixed by this patch as well.
Attachment #456841 - Flags: review?(bugspam.Callek)
Comment on attachment 456841 [details] [diff] [review] second step: fix Windows a=Callek too.
Attachment #456841 - Flags: review?(bugspam.Callek) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/2075bf73c39d - so this is fixed for the moment.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: