Closed Bug 577904 Opened 10 years ago Closed 9 years ago

mark DEBUG only variables as ifdef DEBUG in media

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456730 - Flags: review?(chris.double)
Attachment #456730 - Flags: review?(chris.double) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
chris: note that this is blocked by bug 577899.
Keywords: checkin-needed
Whiteboard: [needs landing] → [pending resolution of 577899]
Attachment #456730 - Attachment is obsolete: true
Attachment #463489 - Flags: review+
Summary: use NS_DEBUG_ASSIGN for media → mark DEBUG only variables as ifdef DEBUG in media
Whiteboard: [pending resolution of 577899]
Attachment #463489 - Flags: approval2.0?
Comment on attachment 463489 [details] [diff] [review]
using #ifdef DEBUG

This should land after we branch for Gecko 2.0 / Firefox 4.
Attachment #463489 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/5e7f5f26e6d4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
You need to log in before you can comment on or make changes to this bug.