mark DEBUG only variables as ifdef DEBUG in media

RESOLVED FIXED in mozilla5

Status

()

Core
Audio/Video
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla5
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.35 KB, patch
timeless
: review+
dbaron
: approval2.0-
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
this is part of a crusade to get rid of compilation warnings
(Assignee)

Comment 1

8 years ago
Created attachment 456730 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456730 - Flags: review?(chris.double)

Updated

8 years ago
Attachment #456730 - Flags: review?(chris.double) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
(Assignee)

Comment 2

8 years ago
chris: note that this is blocked by bug 577899.
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Whiteboard: [needs landing] → [pending resolution of 577899]
(Assignee)

Comment 3

8 years ago
Created attachment 463489 [details] [diff] [review]
using #ifdef DEBUG
Attachment #456730 - Attachment is obsolete: true
Attachment #463489 - Flags: review+
(Assignee)

Updated

8 years ago
Summary: use NS_DEBUG_ASSIGN for media → mark DEBUG only variables as ifdef DEBUG in media
Whiteboard: [pending resolution of 577899]
(Assignee)

Updated

7 years ago
Attachment #463489 - Flags: approval2.0?
Comment on attachment 463489 [details] [diff] [review]
using #ifdef DEBUG

This should land after we branch for Gecko 2.0 / Firefox 4.
Attachment #463489 - Flags: approval2.0? → approval2.0-

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/5e7f5f26e6d4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Can someone confirm if this is fixed?
You need to log in before you can comment on or make changes to this bug.