mark DEBUG only variables as ifdef DEBUG in jsd

RESOLVED FIXED in mozilla5

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla5
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

927 bytes, patch
timeless
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
this is part of a crusade to get rid of compilation warnings
(Assignee)

Comment 1

8 years ago
Created attachment 456737 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456737 - Flags: review?(cbiesinger)
Attachment #456737 - Flags: review?(cbiesinger) → review+
I'm not really a jsd peer though...
(Assignee)

Comment 3

7 years ago
Created attachment 463497 [details] [diff] [review]
using #ifdef DEBUG
Attachment #456737 - Attachment is obsolete: true
Attachment #463497 - Flags: review+
(Assignee)

Updated

7 years ago
Summary: use NS_DEBUG_ASSIGN for jsd → mark DEBUG only variables as ifdef DEBUG in jsd
(Assignee)

Updated

7 years ago
Attachment #463497 - Flags: approval2.0?
Attachment #463497 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 463497 [details] [diff] [review]
using #ifdef DEBUG

Removing approval - this has been sitting since August. Renominate if someone can show me that this hasn't bitrotten and is still needed.
Attachment #463497 - Flags: approval2.0+
Keywords: checkin-needed
(Assignee)

Comment 5

7 years ago
beltzner: i'm the module owner. it applied as of the last time i did a qrefresh to my queue:
http://hg.mozilla.org/users/timeless_mozdev.org/mozilla-central-mq/file/default/

i'm not quite sure what proof you want. but give me an airline ticket to your location and i'll gladly show you whatever proof you request.

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/c40128a92338
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.