Closed Bug 577912 Opened 10 years ago Closed 9 years ago

mark DEBUG only variables as ifdef DEBUG in intl

Categories

(Core :: Internationalization, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — Splinter Review
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #456739 - Flags: review?(smontagu)
Comment on attachment 456739 [details] [diff] [review]
patch

I don't see any reason for a change like this to require per-module review. rsmoa=me iff the NS_DEBUG_ASSIGN thingy itself gets r+

My $0.02 on that: what would be wrong with just doing

#ifdef DEBUG
  foo = 
#endif
  bar(baz);

in all these cases? I agree it's butt-ugly, but it makes it much clearer what I think this is trying to do (and if I have misunderstood what it's trying to do, that actually strengthens my point ;-) ).

What I like least about this it that it's not intuitively obvious what exactly is going to happen in a non-debug build. OT1H NS_DEBUG macros don't evaluate their arguments, OTOH the rhs isn't actually an argument of the macro, so what happens? (That's a rhetorical question -- I'm sure it has a simple answer, but the point is that the question shouldn't arise).
Attachment #456739 - Flags: review?(smontagu)
Attachment #456739 - Attachment is obsolete: true
Attachment #463499 - Flags: review+
Summary: use NS_DEBUG_ASSIGN for intl → mark DEBUG only variables as ifdef DEBUG in intl
I'm glad you finally homed in on what I suggested 4 weeks ago ;-)
Attachment #463499 - Flags: approval2.0?
Attachment #463499 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/61aa163cf951
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.