Closed Bug 577915 Opened 14 years ago Closed 13 years ago

mark DEBUG only variables as ifdef DEBUG in libjar

Categories

(Core :: Networking: JAR, defect)

Product:
Core
Component:
Networking: JAR
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

using #ifdef DEBUG
2.73 KB, patch
timeless
: review+
jst
: approval2.0+
Details | Diff | Splinter Review 
this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #456742 -
        Flags: review?

    
  

        Attachment #456742 -
        Flags: review? → review?(dveditz)

    
    

    
  
Comment on attachment 456742 [details] [diff] [review]
patch

r=dveditz

        Attachment #456742 -
        Flags: review?(dveditz) → review+

    
    

    
  


  

        Attachment #456742 -
        Attachment is obsolete: true

        Attachment #463502 -
        Flags: review+

    
  
Summary: use NS_DEBUG_ASSIGN for libjar → mark DEBUG only variables as ifdef DEBUG in libjar

    
  

        Attachment #463502 -
        Flags: approval2.0?

        Attachment #463502 -
        Flags: approval2.0? → approval2.0+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/11a85f5c2a34
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12

    
    

    
  
I backed this patch as part of this pushlog <http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7e12e3e16e6c> because of the oranges it caused <http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296852850.1296854923.2345.gz&fulltext=1>.

I'm not sure which one of the bugs was at fault, so I just backed them all out.  The assignee needs to investigate and make sure that his patch has not been the culprit, and then re-add checkin-needed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Relanded all but one of the patches in that push.  For this bug, that's:
http://hg.mozilla.org/mozilla-central/rev/08b8b6576527
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: