Closed Bug 577916 Opened 11 years ago Closed 11 years ago
mark DEBUG only variables as ifdef DEBUG in plugins
this is part of a crusade to get rid of compilation warnings
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Comment on attachment 456743 [details] [diff] [review] patch I don't want to review this until NS_DEBUG_ASSIGN's implementation has been agreed upon, and its implementation is in the tree.
brendan has insisted that we not add a macro, so this is "the way"
Summary: use NS_DEBUG_ASSIGN for plugins → mark DEBUG only variables as ifdef DEBUG in plugins
Attachment #463503 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This broke building an opt build with ref count logging. I think you should have used NS_BUILD_REFCNT_LOGGING as the ifdef
Component: Networking: JAR → Plug-ins
QA Contact: networking.jar → plugins
Attachment #509881 - Flags: review? → review?(joshmoz)
This also broke win32 debug builds. The posted fix addresses the problem.
Comment on attachment 509881 [details] [diff] [review] using #ifdef NS_BUILD_REFCNT_LOGGING Going to approve this to land but I'm unlikely to find time to do so before Monday so feel free to land it
Attachment #509881 - Flags: approval2.0+
Comment on attachment 509881 [details] [diff] [review] using #ifdef NS_BUILD_REFCNT_LOGGING Pushed followup to mozilla-central http://hg.mozilla.org/mozilla-central/rev/eb35c4e6d50e
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.