Closed Bug 577916 Opened 9 years ago Closed 9 years ago

mark DEBUG only variables as ifdef DEBUG in plugins

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(2 files, 1 obsolete file)

this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456743 - Flags: review?(joshmoz)
Comment on attachment 456743 [details] [diff] [review]
patch

I don't want to review this until NS_DEBUG_ASSIGN's implementation has been agreed upon, and its implementation is in the tree.
Attachment #456743 - Flags: review?(joshmoz)
brendan has insisted that we not add a macro, so this is "the way"
Attachment #456743 - Attachment is obsolete: true
Attachment #463503 - Flags: review?(joshmoz)
Summary: use NS_DEBUG_ASSIGN for plugins → mark DEBUG only variables as ifdef DEBUG in plugins
Attachment #463503 - Flags: review?(joshmoz) → review+
Attachment #463503 - Flags: approval2.0?
Attachment #463503 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/744e274074da
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
This broke building an opt build with ref count logging. I think you should have used NS_BUILD_REFCNT_LOGGING as the ifdef
Component: Networking: JAR → Plug-ins
QA Contact: networking.jar → plugins
Attachment #509881 - Flags: review? → review?(joshmoz)
Attachment #509881 - Flags: review?(joshmoz) → review+
This also broke win32 debug builds. The posted fix addresses the problem.
Comment on attachment 509881 [details] [diff] [review]
using #ifdef NS_BUILD_REFCNT_LOGGING

Going to approve this to land but I'm unlikely to find time to do so before Monday so feel free to land it
Attachment #509881 - Flags: approval2.0+
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.