Closed Bug 577920 Opened 14 years ago Closed 14 years ago

mark DEBUG only variables as ifdef DEBUG in cocoa

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 1 obsolete file)

this is part of a crusade to get rid of compilation warnings
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #456747 - Flags: review?(joshmoz)
Comment on attachment 456747 [details] [diff] [review]
patch

I don't want to review this until NS_DEBUG_ASSIGN's implementation has been agreed upon, and its implementation is in the tree.
Attachment #456747 - Flags: review?(joshmoz)
brendan has insisted that we not add a macro, so this is "the way"
Attachment #456747 - Attachment is obsolete: true
Attachment #463516 - Flags: review?(joshmoz)
Summary: use NS_DEBUG_ASSIGN for cocoa → mark DEBUG only variables as ifdef DEBUG in cocoa
Attachment #463516 - Flags: review?(joshmoz) → review+
Attachment #463516 - Flags: approval2.0?
Attachment #463516 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7cd79e8d80c8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: