577948 - Rename "filename" option of sandbox.evaluate() to something that makes it obvious it's a string URL

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Nickolay_Ponomarev]

Since files in Mozilla platform can be referred to using many kinds of objects (nsIFiles, OS-specific path, URL, nsIURI, ...) we should be careful to use the correct terms when naming variables (esp. those included in APIs).

Having options.filename in sandbox.evaluate() (and other code which eventually calls it) hold a string URL makes it easier to make mistakes when writing and thinking about code.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

I believe this bug is not longer valid. Our `sandbox` module doesn't have any `options` object for `evaluate`.