Last Comment Bug 578003 - E-mail notifications are missing datetime for comments
: E-mail notifications are missing datetime for comments
Status: RESOLVED FIXED
: regression
Product: Bugzilla
Classification: Server Software
Component: Email Notifications (show other bugs)
: 3.6.1
: All All
: -- minor (vote)
: Bugzilla 3.6
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on: 472217
Blocks: bmo-regressions-1007
  Show dependency treegraph
 
Reported: 2010-07-12 02:03 PDT by Reed Loden [:reed] (use needinfo?)
Modified: 2010-07-12 16:19 PDT (History)
5 users (show)
mkanat: approval+
mkanat: approval4.0+
mkanat: blocking4.0+
mkanat: approval3.6+
mkanat: blocking3.6.2+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (929 bytes, patch)
2010-07-12 02:53 PDT, Frédéric Buclin
glob: review+
Details | Diff | Splinter Review

Description Reed Loden [:reed] (use needinfo?) 2010-07-12 02:03:26 PDT
The "comment from" lines in e-mail notifications are missing their datetime (it's blank).

Example:
--- Comment #5 from Reed Loden [:reed] <reed@reedloden.com>  ---

LpSolit said he was seeing this upstream, as well.
Comment 1 Frédéric Buclin 2010-07-12 02:42:27 PDT
Note that I'm personally in favor of having the date going away definitely as this information is already in the Date: header of bugmails.
Comment 2 Frédéric Buclin 2010-07-12 02:53:46 PDT
Created attachment 456825 [details] [diff] [review]
patch, v1

The method to get the time when a comment was added is creation_ts(), not time().
Comment 3 Frédéric Buclin 2010-07-12 03:01:31 PDT
This is a regression due to bug 472217, which changed $comment->{'time'} to $comment->creation_ts (internally: $comment->{'bug_when'}). So this affects 3.6 and newer only.
Comment 4 Byron Jones ‹:glob› [PTO until 2016-10-10] 2010-07-12 05:18:54 PDT
Comment on attachment 456825 [details] [diff] [review]
patch, v1

r=glob
Comment 5 Max Kanat-Alexander 2010-07-12 13:34:27 PDT
  However, I do agree with LpSolit--for any branch where reed's fix went in that makes the Date header reflect delta_ts, it's probably unnecessary to include dates in the comment headers. The only case that this would be useful for is if there are multiple comments in one email, but that is a pretty rare case.
Comment 6 Max Kanat-Alexander 2010-07-12 13:34:50 PDT
  (The non-inclusion of Date headers should be a separate bug though.)
Comment 7 Frédéric Buclin 2010-07-12 16:19:17 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7329.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7307.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7132.

Note You need to log in before you can comment on or make changes to this bug.