Closed Bug 578003 Opened 10 years ago Closed 10 years ago

E-mail notifications are missing datetime for comments

Categories

(Bugzilla :: Email Notifications, defect)

3.6.1
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: reed, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

The "comment from" lines in e-mail notifications are missing their datetime (it's blank).

Example:
--- Comment #5 from Reed Loden [:reed] <reed@reedloden.com>  ---

LpSolit said he was seeing this upstream, as well.
Flags: blocking4.0?
Flags: blocking3.6.2?
Keywords: regression
Note that I'm personally in favor of having the date going away definitely as this information is already in the Date: header of bugmails.
Attached patch patch, v1Splinter Review
The method to get the time when a comment was added is creation_ts(), not time().
Assignee: email-notifications → LpSolit
Status: NEW → ASSIGNED
Attachment #456825 - Flags: review?(bugzilla)
This is a regression due to bug 472217, which changed $comment->{'time'} to $comment->creation_ts (internally: $comment->{'bug_when'}). So this affects 3.6 and newer only.
Severity: normal → minor
Depends on: 472217
Comment on attachment 456825 [details] [diff] [review]
patch, v1

r=glob
Attachment #456825 - Flags: review?(bugzilla) → review+
Flags: approval?
Flags: approval4.0?
Flags: approval3.6?
  However, I do agree with LpSolit--for any branch where reed's fix went in that makes the Date header reflect delta_ts, it's probably unnecessary to include dates in the comment headers. The only case that this would be useful for is if there are multiple comments in one email, but that is a pretty rare case.
Flags: blocking4.0?
Flags: blocking4.0+
Flags: blocking3.6.2?
Flags: blocking3.6.2+
Flags: approval?
Flags: approval4.0?
Flags: approval4.0+
Flags: approval3.6?
Flags: approval3.6+
Flags: approval+
  (The non-inclusion of Date headers should be a separate bug though.)
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7329.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7307.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7132.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.