578012 - with --enable-C, test suite doesn't pass if CXX doesn't end in "g++"

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Mike Hommey [:glandium]]

On Debian systems, and I believe a lot of other distros, gcc/g++ can be called with a -x.y suffix for the version. gcc and g++ without the suffix will usually use the system default version, which is not necessarily the right one to build dehydra. At the moment, debian default is 4.4, which means to use g++ 4.5, I need to invoke g++-4.5. The string replacing that occurs in test/unit_test_harness.py makes that g++-4cc for the C counterpart, which fails for obvious reasons.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

This should work.

Comment 2

[(dormant account)]

Comment on attachment 456835 [details] [diff] [review]
Patch

The proper fix is to check for $CC in configure, but this will do for now

Comment 3

[Mike Hommey [:glandium]]

Do you want me to check that in?

Comment 4

[(dormant account)]

(In reply to comment #3)
> Do you want me to check that in?

Yes please.

Comment 5

[Mike Hommey [:glandium]]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/3f2df954a44f