578123 - New Feedback page for Fx 4 beta 2

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect, P1)

Description

[Laura Mesa [:lmesa] [:lvmesa]]

Like to replace the current page with the attached PSD of the new Feedback page.

Want to add survey gizmo poll functionality and add SUMO promo.

Comment 1

[Laura Mesa [:lmesa] [:lvmesa]]

https://www.yousendit.com/dl?phi_action=app/orchestrateDownload&rurl=https%253A%252F%252Fwww.yousendit.com%252Ftransfer.php%253Faction%253Dbatch_download%2526send_id%253D907758645%2526email%253D2fa9bdd106b0eb041df4df892c4c5fac

Comment 2

[Laura Mesa [:lmesa] [:lvmesa]]

It would be great to have this page ready built in the enxt day or so, especially because it had to be ready to be localized on Friday.

Comment 3

[Steven Garrity [:sgarrity]]

This page is setup in trunk in r70398. Un-styling SurveyGizmo cost me much of my day though.

Comment 4

[Laura Mesa [:lmesa] [:lvmesa]]

Change of SUMO promo wording to:
Need Help?
Our support pages have answers and advice specifically for the Firefox 4 beta.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

The SUMO promo is unlinked.

Comment 6

[John Slater]

(In reply to comment #5)
> The SUMO promo is unlinked.

There's supposed to be a link in there...let's try it like this:

Need Help?
_Our support pages_ have answers and advice specifically for the Firefox 4 beta.

Comment 7

[Laura Mesa [:lmesa] [:lvmesa]]

Just got confirmation from Cheng, but these promos will not go live with beta 2--we're keeping them on the page so that the localizers can translate them, but they will not be visible until beta 3, when they will go live.

Comment 8

[Steven Garrity [:sgarrity]]

Updated the SUMO promo/link in r70449.

(In reply to comment #7)
> Just got confirmation from Cheng, but these promos will not go live with beta
> 2--we're keeping them on the page so that the localizers can translate them,
> but they will not be visible until beta 3, when they will go live.

Should I hide them with CSS? (which promos?)

Comment 9

[Laura Mesa [:lmesa] [:lvmesa]]

(In reply to comment #8)
> Updated the SUMO promo/link in r70449.
> 
> (In reply to comment #7)
> > Just got confirmation from Cheng, but these promos will not go live with beta
> > 2--we're keeping them on the page so that the localizers can translate them,
> > but they will not be visible until beta 3, when they will go live.
> 
> Should I hide them with CSS? (which promos?)

That sould be great--just the SUMO promo "Need Help?".

Comment 10

[Steven Garrity [:sgarrity]]

(In reply to comment #9)
> That sould be great--just the SUMO promo "Need Help?".

Done, along with text updates and reorganization discussed via IM, in r70475.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

1) Currently, there are two <span> validation errors
2) Also, I can "Vote" without selecting anything, and it just gives me a list of 0%-completed results

Comment 12

[Steven Garrity [:sgarrity]]

(In reply to comment #11)
> 1) Currently, there are two <span> validation errors
Validation error fixed in r70477. Thanks.

> 2) Also, I can "Vote" without selecting anything, and it just gives me a list
> of 0%-completed results
Laura, can you check with SurveyGizmo about this? Is this the intended behaviour?

Comment 13

[Laura Mesa [:lmesa] [:lvmesa]]

> > 2) Also, I can "Vote" without selecting anything, and it just gives me a list
> > of 0%-completed results
> Laura, can you check with SurveyGizmo about this? Is this the intended
> behaviour?

I'll check it out.

Comment 14

[Laura Mesa [:lmesa] [:lvmesa]]

Update--called and sent email with no SG response. Hoping for one tomorrow :(

Comment 15

[Laura Mesa [:lmesa] [:lvmesa]]

Okay, just talked to SG--

so, it is expected behavior that if you just press "vote" without choosing an answer to get the results window and to not be able to go back.  That's there way of controlling for people who just keep on voting. I don't want to make the questions required (shitty user experience) but as long as  the poll is registering votes correctly when someone does input an answer, I think we're okay. 

Does that help, Stephen?

Comment 16

[Steven Garrity [:sgarrity]]

There is a "View Results" link in the form footer that I've hidden with CSS (it's before the "Vote" button, and it seemed like an unnecessary distraction. I think we're probably fine how we are though.

The "0%-completed results" is just a side-effect of the survey not having been run yet. It might be a bit less disorienting when you see real results.

Comment 17

[Laura Mesa [:lmesa] [:lvmesa]]

This page looks done to me--marking fixed.

Comment 18

[Laura Mesa [:lmesa] [:lvmesa]]

I think we can push this page once QA takes a look--no need to wait for beta 2.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing layout issue when voting and then erroring out on Subscribe

Comment 20

[Stephen DesRoches]

I've added a taller background in r70760.  This should fix that problem.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www-trunk.stage.mozilla.com/en-US/firefox/beta/feedback/.

Comment 22

[Laura Mesa [:lmesa] [:lvmesa]]

Please push, asap.

Comment 23

[Steven Garrity [:sgarrity]]

(In reply to comment #22)
> Please push, asap.

Laura, do you want the entire new page layout pushed?

Comment 24

[Laura Mesa [:lmesa] [:lvmesa]]

Yes please!

Comment 25

[Steven Garrity [:sgarrity]]

Merged all of these changes (-r70397:70398, -r70448:70449, -r70474:70475, -r70476:70477, -r70759:70760) from trunk to stage in r71010).

Alex, can you handle the push to production (it's just r71010)?

Comment 26

[Alex Buchanan [:abuchanan]]

r71013 on production

Thanks Steven

Comment 27

[Alex Buchanan [:abuchanan]]

Submitting the newsletter form leads to a blank page :(

Comment 28

[Alex Buchanan [:abuchanan]]

This error is caused by the SurveyGizmo script.  It loads it's own version of jquery, which overrides our version and breaks anything using jquery

I'm waiting on a SurveyGizmo login to fix this.

Comment 29

[Laura Mesa [:lmesa] [:lvmesa]]

gave login to Alex B yesterday.

Comment 30

[Alex Buchanan [:abuchanan]]

r71180 fixes the newsletter form,

This was caused by SurveyGizmo, becaue it loads it's own version of jquery, which breaks any jquery JS we have.  The workaround is to put our JS in $extra_footers, so it loads after surveygizmo.  Something to watch out for.  

I have a ticket open with SurveyGizmo to improve their survey JS and fix this issue.

Comment 31

[Alex Buchanan [:abuchanan]]

r71187 on production

Comment 32

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www.mozilla.com/en-US/firefox/beta/feedback/; made sure to double-check the Survey Gizmo survey this time (empty/real voting).

Comment 33

[Pascal Chevrel:pascalc]

I found text messages in the newsletter-form.js that were local variables that could not be redefined for l10n. I moved them outside of the function as variables in r71293 to fix that problem. Works for me locally with no impact on en-US but feel free to recheck.

Comment 34

[My]

Re: newsletter-form.js, I just checked and seemed to work fine on this end.

Comment 35

[Alex Buchanan [:abuchanan]]

Would it be better to use main.lang and put them in the form HTML?

Comment 36

[Pascal Chevrel:pascalc]

Alex, those strings are already in main.lang for locales, works fine :)