57819 - cut down large mysql error strings

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Nick Hibma]

If msql reports a problem, the resulting strings can be large. Example, 
submitting a 10Mb file as an attachment (which fails) shows up with a missing
quote error. This takes aaaaaages to download.

Patch attached. Against todays bugzilla.

The patch takes out the middle bit and leaves the beginning and end of the 
error message in tact.

Comment 1

[Nick Hibma]

Make the URL a FQHN

Comment 2

[Dave Miller [:justdave]]

moving to real milestones...

Comment 3

[Stephan Niemz]

The URL for the patch is wrong (patch for bug 57818).
Updating to what I guess is the right URL.

Comment 4

[Stephan Niemz]

Attachment: the mentioned patch, just in case ...

Comment 5

[Andreas Franke (gone)]

-> Bugzilla product, General component (error reporting issue, globals.pl),
reassigning.

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 26537 [details] [diff] [review]
the mentioned patch, just in case ...

r=Gerv.

Gerv

Comment 7

[Jacob Steenhagen]

Setting owner to patch writer...

Comment 8

[Gervase Markham [:gerv]]

/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.115; previous revision: 1.114

Gerv

Comment 9

[Dave Miller [:justdave]]

I don't want this.  Please back it out.

I know the big strings are a waste to the users, but there have been cases in
the past where we only solved a bug because we had the whole string to look at.

How about we compromise and extract the actual error message out and display
that first (instead of last, at the end of the sql garbage), then put "the
complete error message was: " and the original message or something.

Comment 10

[Dave Miller [:justdave]]

Hmm...  I see the original report was because of error messages on attachments...

How about if we keep a bigger chunk of it?  I agree we wouldn't want the whole
darn attachment repeated back in the error...

But we should probably keep 1K or 2K or so off each end...  (much more than 100
characters at least...)

Comment 11

[Gervase Markham [:gerv]]

> I don't want this.  Please back it out.

Could we expand to, say, 5000 characters? That'll exclude the file upload
problem the reporter mentions, but include any sane SQL query string.

Or we could do your idea; but having never seen one of these errors, I'm not
sure how to do the matching.

Gerv

Comment 12

[Gervase Markham [:gerv]]

Is the important info at the beginning, or the end, or both?

Gerv

Comment 13

[Dave Miller [:justdave]]

the important info is usually right at the end...

here's a quickly-hacked example:

SELECT blah, bugs.bug_id, bugs.groupset, substring(bugs.bug_severity, 1, 3),
substring(bugs.priority, 1, 3), substring(bugs.rep_platform, 1, 3),
map_assigned_to.login_name, substring(bugs.bug_status,1,4),
substring(bugs.resolution,1,4), substring(bugs.short_desc, 1, 60) FROM bugs,
profiles map_assigned_to, profiles map_reporter LEFT JOIN profiles
map_qa_contact ON bugs.qa_contact = map_qa_contact.userid WHERE bugs.assigned_to
= map_assigned_to.userid AND bugs.reporter = map_reporter.userid AND
bugs.groupset & 0 = bugs.groupset AND (bugs.bug_status = 'NEW' OR
bugs.bug_status = 'ASSIGNED' OR bugs.bug_status = 'REOPENED') GROUP BY
bugs.bug_id ORDER BY bugs.priority, bugs.bug_severity: Unknown column 'blah' in
'field list' at globals.pl line 219.

Comment 14

[Gervase Markham [:gerv]]

OK, let's go for 2k at the beginning, 2k at the end, and see if we encounter
problems. Patch coming up.

Gerv

Comment 15

[Gervase Markham [:gerv]]

Attachment: Patch to upgrade to 2000 chars at front and back

Comment 16

[Dave Miller [:justdave]]

Comment on attachment 53441 [details] [diff] [review]
Patch to upgrade to 2000 chars at front and back

I'll go for that.

r= justdave

Comment 17

[Gervase Markham [:gerv]]

Checked in. This is too trivial to bother anyone else with.

/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.119; previous revision: 1.118

Gerv

Comment 18

[Dave Miller [:justdave]]

heh.  agreed.  Thanks!