Closed Bug 578618 Opened 10 years ago Closed 10 years ago

Make /sys/kernel/high_watermark check MAEMO=5 only

Categories

(Core :: XPCOM, defect)

Other Branch
x86
Maemo
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Make maemo5 only mem check (obsolete) — Splinter Review
we are checking special file and not using any system API for handling low memory on maemo... and that is common now for all maemo platforms...

I think we should make current implementation MAEMO 5 only,

and then find proper low mem API for maemo/meego platform
Attachment #457275 - Flags: review?(doug.turner)
Comment on attachment 457275 [details] [diff] [review]
Make maemo5 only mem check

what about MOZ_PLATFORM_MAEMO == 4
> what about MOZ_PLATFORM_MAEMO == 4
Will (MOZ_PLATFORM_MAEMO <= 5) work?
Attached patch mem <= 5 (obsolete) — Splinter Review
Assignee: nobody → romaxa
Attachment #457275 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #459577 - Flags: review?(doug.turner)
Attachment #457275 - Flags: review?(doug.turner)
Comment on attachment 459577 [details] [diff] [review]
mem <= 5

we are about to remove this code very soon and replacing it with a new system.
Attachment #459577 - Flags: review?(doug.turner) → review+
Comment on attachment 459577 [details] [diff] [review]
mem <= 5

gnu doesn't support comparisons.  :(
Attachment #459577 - Flags: review+ → review-
Attached patch ==5 || ==4Splinter Review
Attachment #459577 - Attachment is obsolete: true
Attachment #459715 - Flags: review?(doug.turner)
> 
> we are about to remove this code very soon and replacing it with a new system.

my goal here is get rid of annoying NS_ERRORS on maemo platform > 5
Attachment #459715 - Flags: review?(doug.turner) → review+
Blocks: 583135
http://hg.mozilla.org/mozilla-central/rev/cb95b8d67bdd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.