Closed Bug 578672 Opened 14 years ago Closed 14 years ago

Need sendSyncMessage for messages that require a return value

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: vingtetun)

References

Details

Attachments

(1 file)

When we converted to use sendAsyncMessage in Fennec we broke at least two messages that can have a return value: "DOMWindowClose" and "DOMWillOpenModalDialog"

http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings/browser.js#292

That should be a "sendSyncMessage"
Attached patch PatchSplinter Review
Since I've relanded the platform patch for preventing the error in SendSyncMessage this morning I think this simple change should do it.
Attachment #457509 - Flags: review?(mark.finkle)
Attachment #457509 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/db21b5d9b799
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: